From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E7626955D3 for ; Wed, 18 Jan 2023 12:50:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D03C11F6B9 for ; Wed, 18 Jan 2023 12:50:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 12:50:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B367B44F73 for ; Wed, 18 Jan 2023 12:50:22 +0100 (CET) Date: Wed, 18 Jan 2023 12:50:20 +0100 From: Christoph Heiss To: Proxmox Backup Server development discussion Message-ID: <20230118115020.w5aqflxqwrhr6r7l@maui.proxmox.com> References: <20230118104903.441554-1-c.heiss@proxmox.com> <20230118104903.441554-3-c.heiss@proxmox.com> <1674040346.a6cksp257q.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1674040346.a6cksp257q.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.403 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 2/6] client: Add `--protected` CLI flag to backup command X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 11:50:24 -0000 On Wed, Jan 18, 2023 at 12:13:52PM +0100, Fabian Grünbichler wrote: > On January 18, 2023 11:48 am, Christoph Heiss wrote: > > [..] > > @@ -1082,7 +1089,9 @@ async fn create_backup( > > .upload_blob_from_data(manifest.into_bytes(), MANIFEST_BLOB_NAME, options) > > .await?; > > > > - client.finish().await?; > > + client.finish(Some(json!({ > > + "protected": protected, > > + }))).await?; > > this fails the backup with new client + --protected, at the very end, if the > server doesn't have patch #1 of this series. Right, I did not test _that_ combination. Thanks for taking a look, I will fix it for the next revision! > > we need some sort of compat mechanism... One approach here would be to check the server version using the `/version` endpoint and decide on that. (And re-reading that, Fiona actually brought up that exact point in the previous thread ..) FWIW, a (more) future-proof and cleaner compat mechanism could maybe be to have `/version` also return a list of features supported by the server, beside the current fields? E.g. { "data": { "release": "2", "repoid": "07151513fa92899c65b1efa47d9b2d40c5dc5d82", "version": "2.3", "features": ["finish-protected-param"] <-- }, "success": true } Would something like that be acceptable? Just an idea. > > > > > let end_time = std::time::Instant::now(); > > let elapsed = end_time.duration_since(start_time); > > -- > > 2.34.1 > > > > > > > > _______________________________________________ > > pbs-devel mailing list > > pbs-devel@lists.proxmox.com > > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > > > > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >