From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 626DA954D4 for ; Wed, 18 Jan 2023 11:49:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F6761EAF6 for ; Wed, 18 Jan 2023 11:49:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 11:49:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 132E144E70 for ; Wed, 18 Jan 2023 11:49:53 +0100 (CET) From: Christoph Heiss To: pbs-devel@lists.proxmox.com Date: Wed, 18 Jan 2023 11:49:02 +0100 Message-Id: <20230118104903.441554-6-c.heiss@proxmox.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230118104903.441554-1-c.heiss@proxmox.com> References: <20230118104903.441554-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [RFC PATCH qemu-server 5/6] vzdump: Set protected flag on backup start if supported X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 10:49:54 -0000 Signed-off-by: Christoph Heiss --- PVE/VZDump/QemuServer.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 0eb5ec6..1d1131c 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -477,6 +477,13 @@ my sub add_backup_performance_options { } } +my sub backup_client_supports_protected_flag { + my $supported; + PVE::Tools::run_command(['/usr/bin/proxmox-backup-client', 'help', 'backup'], + logfunc => sub { $supported = 1 if shift =~ m/--protected/ }); + return $supported; +} + sub archive_pbs { my ($self, $task, $vmid) = @_; @@ -515,6 +522,10 @@ sub archive_pbs { push @$cmd, '--ns', $ns; } + if ($opts->{protected} && backup_client_supports_protected_flag()) { + push @$cmd, '--protected', '1'; + } + push @$cmd, "qemu-server.conf:$conffile"; push @$cmd, "fw.conf:$firewall" if -e $firewall; @@ -603,6 +614,9 @@ sub archive_pbs { $params->{'use-dirty-bitmap'} = JSON::true if $qemu_support->{'pbs-dirty-bitmap'} && !$is_template; + $params->{'protected'} = JSON::true + if $qemu_support->{'pbs-protected-flag'} && $opts->{protected}; + $params->{timeout} = 125; # give some time to connect to the backup server my $res = eval { mon_cmd($vmid, "backup", %$params) }; -- 2.34.1