From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CBC4194D1F for ; Mon, 16 Jan 2023 09:21:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3E1F23969 for ; Mon, 16 Jan 2023 09:21:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 16 Jan 2023 09:21:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E2FE44281 for ; Mon, 16 Jan 2023 09:21:45 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 16 Jan 2023 09:21:44 +0100 Message-Id: <20230116082144.638492-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] fix #4466: show snapshots in media content again X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2023 08:21:45 -0000 while refactoring the the empty media set checks, we accidentally reversed one check from !is_empty to unassigned, which now never included the right media sets. reversing the condition fixes that. fixes 52517f7b: ("tape: hide internal use of all zero uuid for unassigned tapes") Signed-off-by: Dominik Csapak --- src/tape/inventory.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs index dd560179..1817ab2e 100644 --- a/src/tape/inventory.rs +++ b/src/tape/inventory.rs @@ -294,7 +294,7 @@ impl Inventory { match entry.id.media_set_label { None => continue, // not assigned to any pool Some(ref set) => { - if set.unassigned() { + if !set.unassigned() { list.push(entry.id.clone()); } } -- 2.30.2