From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 26A6091967 for ; Thu, 22 Dec 2022 13:06:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08B331B082 for ; Thu, 22 Dec 2022 13:06:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Dec 2022 13:06:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A2F4644CAB for ; Thu, 22 Dec 2022 13:06:25 +0100 (CET) From: Christoph Heiss To: pbs-devel@lists.proxmox.com Date: Thu, 22 Dec 2022 13:05:48 +0100 Message-Id: <20221222120549.3958127-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v2 proxmox-backup/widget-toolkit] Handle optional services and expose more details X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2022 12:06:57 -0000 Add the `unit-state` property for services to the PBS api, much like it's PVE counterpart. This avoids erroneously marking services as dead that might be just not installed, e.g. systemd-timesyncd. On the GUI side, this functionality already exists (from PVE), just the appropriate cookie name needs to be added. See also #4406. --- Changes since v1: * Fall back to `SubState` if `Result` is not present --- proxmox-backup: Christoph Heiss (1): api2/node/services: Handle optional services and expose unit-state src/api2/node/services.rs | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) proxmox-widget-toolkit: Christoph Heiss (1): node/ServiceView: Show unit-state column in PBS too src/node/ServiceView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)