From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6E1E1EF38 for ; Tue, 13 Dec 2022 14:54:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 470012044B for ; Tue, 13 Dec 2022 14:53:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Dec 2022 14:53:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6199D432F2 for ; Tue, 13 Dec 2022 14:53:57 +0100 (CET) Date: Tue, 13 Dec 2022 14:53:56 +0100 From: Wolfgang Bumiller To: Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Cc: pbs-devel@lists.proxmox.com Message-ID: <20221213135356.xgcyu5srst7kdlh2@casey.proxmox.com> References: <20221213133755.751536-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221213133755.751536-1-f.gruenbichler@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.221 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox 1/2] section-config: make ReST dump reproducible X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2022 13:54:28 -0000 applied both patches, thanks On Tue, Dec 13, 2022 at 02:37:54PM +0100, Fabian Grünbichler wrote: > HashMaps are not ordered, so each package build containing a section config > dump would have the documentation ordered randomly. > > Signed-off-by: Fabian Grünbichler > --- > tested PBS build with the resulting proxmox-section-config crate, the -docs > package is now reproducible ;) > > proxmox-section-config/src/lib.rs | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/proxmox-section-config/src/lib.rs b/proxmox-section-config/src/lib.rs > index 1706718..51f6770 100644 > --- a/proxmox-section-config/src/lib.rs > +++ b/proxmox-section-config/src/lib.rs > @@ -1110,10 +1110,13 @@ token: asdf@pbs!asdftoken > pub fn dump_section_config(config: &SectionConfig) -> String { > let mut res = String::new(); > > + let mut plugins: Vec<&String> = config.plugins().keys().collect(); > + plugins.sort_unstable(); > + > let plugin_count = config.plugins().len(); > > - for plugin in config.plugins().values() { > - let name = plugin.type_name(); > + for name in plugins { > + let plugin = config.plugins().get(name).unwrap(); > let properties = plugin.properties(); > let skip = match plugin.id_property() { > Some(id) => vec![id], > -- > 2.30.2