From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B7F59EEC8 for ; Tue, 13 Dec 2022 14:39:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9348B20239 for ; Tue, 13 Dec 2022 14:39:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Dec 2022 14:39:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C392D43EFD for ; Tue, 13 Dec 2022 14:39:28 +0100 (CET) Date: Tue, 13 Dec 2022 14:39:28 +0100 From: Wolfgang Bumiller To: Christoph Heiss Cc: pbs-devel@lists.proxmox.com Message-ID: <20221213133928.yrpugzxbxs5f453p@casey.proxmox.com> References: <20221212141056.180468-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221212141056.180468-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.221 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup] fix #4346: pbs-client: don't fail silently when storing ticket X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2022 13:39:59 -0000 applied, thanks On Mon, Dec 12, 2022 at 03:10:56PM +0100, Christoph Heiss wrote: > Instead, report an error if storing the ticket info failed, so that the > user is informed that something went wrong and follow-up commands might > require authentication again. > > Signed-off-by: Christoph Heiss > --- > pbs-client/src/http_client.rs | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs > index c78d08f3..256b3cfa 100644 > --- a/pbs-client/src/http_client.rs > +++ b/pbs-client/src/http_client.rs > @@ -452,13 +452,15 @@ impl HttpClient { > { > Ok(auth) => { > if use_ticket_cache && prefix2.is_some() { > - let _ = store_ticket_info( > + if let Err(err) = store_ticket_info( > prefix2.as_ref().unwrap(), > &server2, > &auth.auth_id.to_string(), > &auth.ticket, > &auth.token, > - ); > + ) { > + log::error!("storing login ticket failed: {}", err); > + } > } > *auth2.write().unwrap() = auth; > } > @@ -486,13 +488,15 @@ impl HttpClient { > > move |auth| { > if use_ticket_cache && prefix.is_some() { > - let _ = store_ticket_info( > + if let Err(err) = store_ticket_info( > prefix.as_ref().unwrap(), > &server, > &auth.auth_id.to_string(), > &auth.ticket, > &auth.token, > - ); > + ) { > + log::error!("storing login ticket failed: {}", err); > + } > } > *authinfo.write().unwrap() = auth; > tokio::spawn(renewal_future); > -- > 2.30.2