From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 153E5B98B for ; Thu, 24 Nov 2022 14:47:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED6531021 for ; Thu, 24 Nov 2022 14:47:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 24 Nov 2022 14:47:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 196CE44007 for ; Thu, 24 Nov 2022 14:47:58 +0100 (CET) Date: Thu, 24 Nov 2022 14:47:57 +0100 From: Wolfgang Bumiller To: Dominik Csapak Cc: pbs-devel@lists.proxmox.com Message-ID: <20221124134757.fmjpcsvzpw4io3ey@casey.proxmox.com> References: <20221124101709.2712920-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221124101709.2712920-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.227 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [smart.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] disk: smartctl: ignore bit 2 of exitcode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2022 13:47:59 -0000 applied, thanks On Thu, Nov 24, 2022 at 11:17:09AM +0100, Dominik Csapak wrote: > under some conditions, the smartctl exitcode sets bit 2, even if the > smartctl call succeeded, but has e.g. some warnings derived from the > attributes > > we do the same in pve, but it is only the first step in fixing #4353, since > we probably should parse the smartcl output better to include > such warnings > > Signed-off-by: Dominik Csapak > --- > src/tools/disks/smart.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs > index 180ddfe9..a99404dc 100644 > --- a/src/tools/disks/smart.rs > +++ b/src/tools/disks/smart.rs > @@ -94,7 +94,7 @@ pub fn get_smart_data(disk: &super::Disk, health_only: bool) -> Result let output = proxmox_sys::command::run_command( > command, > Some( > - |exitcode| (exitcode & 0b0111) == 0, // only bits 0-2 are fatal errors > + |exitcode| (exitcode & 0b0011) == 0, // only bits 0-1 are fatal errors > ), > )?; > > -- > 2.30.2