From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CC4D5B0D8 for ; Wed, 23 Nov 2022 11:26:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE05E20DA5 for ; Wed, 23 Nov 2022 11:26:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 23 Nov 2022 11:26:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 03694446FC for ; Wed, 23 Nov 2022 11:26:19 +0100 (CET) From: w.bumiller@proxmox.com Date: Wed, 23 Nov 2022 11:26:18 +0100 To: Lukas Wagner Cc: pbs-devel@lists.proxmox.com Message-ID: <20221123102618.krsjmm6dfwdvxgkt@casey.proxmox.com> Zrom: Wolfgang Bumiller References: <20221028100143.9035-1-l.wagner@proxmox.com> <20221028100143.9035-2-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028100143.9035-2-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.228 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/1] fix #3828: proxmox_backup_debug: Introduce `diff archive` subcommand. X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2022 10:26:55 -0000 Applied and fixe dup the `c/b` entries to show the actual device type. But I would like to see some improvements still. The output is *very* terse and lacks some information that I find is sort of important (ie. *what* changed - size, mtime, type...). Particularly the file type is interesting, since currently if that changes it'll simply display the *old* type in the output. Eg. M f root/asdf where I modified `/root/asdf` from a regular file to a chardev. I'd expect at least the new type ;-) maybe even something like M f>c root/asdf (if we add this, the 2 extra spaces should be added where no change happened for alignment) Or simply '*' for a change if we want to stick to short "it just changed" info... I also think an opt-in to compare the actual contents would make sense. Eg. currently files such as `/etc/hostname` will always show up if the container had been restarted between backups since we re-write it on container start even if it hasn't been changed, so the mtime will be different.