From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 883E08A590 for ; Thu, 20 Oct 2022 09:41:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A40D4111 for ; Thu, 20 Oct 2022 09:41:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Oct 2022 09:41:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2ADFA44AAD for ; Thu, 20 Oct 2022 09:41:00 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 20 Oct 2022 09:40:58 +0200 Message-Id: <20221020074058.717152-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221020074058.717152-1-d.csapak@proxmox.com> References: <20221020074058.717152-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3 5/5] datastore: make 'filesystem' the default sync-level X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 07:41:01 -0000 Signed-off-by: Dominik Csapak --- docs/storage.rst | 4 ++-- pbs-api-types/src/datastore.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/storage.rst b/docs/storage.rst index c4e44c72..d61c3a40 100644 --- a/docs/storage.rst +++ b/docs/storage.rst @@ -344,13 +344,13 @@ and only available on the CLI: the crash resistance of backups in case of a powerloss or hard shutoff. There are currently three levels: - - `none` (default): Does not do any syncing when writing chunks. This is fast + - `none` : Does not do any syncing when writing chunks. This is fast and normally OK, since the kernel eventually flushes writes onto the disk. The kernel sysctls `dirty_expire_centisecs` and `dirty_writeback_centisecs` are used to tune that behaviour, while the default is to flush old data after ~30s. - - `filesystem` : This triggers a ``syncfs(2)`` after a backup, but before + - `filesystem` (default): This triggers a ``syncfs(2)`` after a backup, but before the task returns `OK`. This way it is ensured that the written backups are on disk. This is a good balance between speed and consistency. Note that the underlying storage device still needs to protect itself against diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 15ea80cd..f33fbc2d 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -200,7 +200,7 @@ pub enum DatastoreFSyncLevel { impl Default for DatastoreFSyncLevel { fn default() -> Self { - DatastoreFSyncLevel::None + DatastoreFSyncLevel::Filesystem } } -- 2.30.2