From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 76A7D8B30A for ; Wed, 24 Aug 2022 14:57:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AFAA1A242 for ; Wed, 24 Aug 2022 14:57:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 24 Aug 2022 14:57:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCEA04353C for ; Wed, 24 Aug 2022 14:48:43 +0200 (CEST) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 24 Aug 2022 14:48:24 +0200 Message-Id: <20220824124829.392189-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v5 0/5] refactor datastore locking to use tmpfs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2022 12:57:48 -0000 The first commit fixes a bug in the `BackupGroup`'s `relative_group_path()` method. It would return the full path instead of a path relative to a datastore. Since this function wasn't used before this series, afaict, this fix should be unproblematic. The rests of this series refactors the locking mechanism inside the `DataStore`, `BackupDir` and `BackupGroup traits. In a first step locking methods are added and the existing code is refactored to use them. Commit three uses the fixed `relative_group_path()` method to derive a lock file name under '/run' for each group/snapshot. It also adds double stat'ing. The fourth commit refactors locking for manifests and brings it in-line with the group/snapshot locks. Finally the fifth commit fixes a race condition when changing the owner of a datastore. As far as I can tell, the addition of namespaces did not create a need for more locking. changes from v4 (thanks @ Wolfgang Bumiller): * stop using `to_string_lossy()` * switch funtion signature of `create_locked_backup_group()` and `create_locked_backup_dir` to use the `Arc` version of a datastore. * smaller clippy fixes * rebased on current master changes from v3: * moved patch 2 to the front so it can be applied separatelly more easily * rebased on current master changes from v2: * different encoding scheme for lock file names * refactored locking methods to be used by the new BackupDir and BackupGroup traits * adapted lock file names to include namespaces changes from v1 (thanks @ Wolfgang Bumiller & Thomas Lamprecht): * split adding locking helpers and move '/run' into two commits * instead of stat'ing the path of lock file twice, only use the file descriptor for one of the stat'ing procedures instead * several improvements to helper functions and documentation Stefan Sterz (5): fix: datastore: make relative_group_path() return relative path fix #3935: datastore/api/backup: add lock helpers to backup dir/group fix #3935: datastore/api/backup: move datastore locking to '/run' fix #3935: datastore: move manifest locking to new locking method fix: api: avoid race condition in set_backup_owner pbs-config/src/lib.rs | 7 ++ pbs-datastore/src/backup_info.rs | 154 ++++++++++++++++++++++----- pbs-datastore/src/datastore.rs | 72 +++++-------- pbs-datastore/src/snapshot_reader.rs | 23 ++-- src/api2/admin/datastore.rs | 8 +- src/api2/backup/environment.rs | 5 +- src/api2/backup/mod.rs | 8 +- src/api2/reader/mod.rs | 7 +- src/backup/verify.rs | 11 +- 9 files changed, 192 insertions(+), 103 deletions(-) -- 2.30.2