From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B952C7D778 for ; Thu, 21 Jul 2022 13:46:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AFC17792D for ; Thu, 21 Jul 2022 13:46:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Jul 2022 13:46:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A710426E8 for ; Thu, 21 Jul 2022 13:46:17 +0200 (CEST) Date: Thu, 21 Jul 2022 13:46:16 +0200 From: Wolfgang Bumiller To: Thomas Lamprecht Cc: Proxmox Backup Server development discussion , Mira Limbeck Message-ID: <20220721114616.f74gqbo44xlo3pro@casey.proxmox.com> References: <20220720142040.2140178-1-m.limbeck@proxmox.com> <443436b7-6b7e-e93b-b193-c3d8e1535a10@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <443436b7-6b7e-e93b-b193-c3d8e1535a10@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.279 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [simple.rs] Subject: Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 11:46:47 -0000 On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote: > Am 20/07/2022 um 16:20 schrieb Mira Limbeck: > > and encode the username:password string as base64 [0]. This fixes the > > error 407 issue when using proxy authentication [1]. > > does this break setups that configured "Basic base64-encoded-pw" themselves though, > or was that never possible (e.g., due to schema not allowing that)? That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses it to build "http://@" strings, so the "Basic " prefix and base64 encoding would break those. However, we also build such headers in src/client/simple.rs which should will need the same change I suppose?