From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E99697D37B for ; Wed, 20 Jul 2022 16:28:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF4B8353D2 for ; Wed, 20 Jul 2022 16:28:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Jul 2022 16:28:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 359174274A for ; Wed, 20 Jul 2022 16:20:45 +0200 (CEST) From: Mira Limbeck To: pbs-devel@lists.proxmox.com Date: Wed, 20 Jul 2022 16:20:40 +0200 Message-Id: <20220720142040.2140178-1-m.limbeck@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.193 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 14:28:41 -0000 and encode the username:password string as base64 [0]. This fixes the error 407 issue when using proxy authentication [1]. [0] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Proxy-Authorization [1] https://forum.proxmox.com/threads/checking-the-subscription-behind-a-proxy-fails.112063/ Signed-off-by: Mira Limbeck --- proxmox-http/src/client/connector.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-http/src/client/connector.rs b/proxmox-http/src/client/connector.rs index d6ba9dd..f3e7535 100644 --- a/proxmox-http/src/client/connector.rs +++ b/proxmox-http/src/client/connector.rs @@ -184,8 +184,8 @@ impl hyper::service::Service for HttpsConnector { if let Some(authorization) = authorization { let _ = write!( connect_request, - "Proxy-Authorization: {}\r\n", - authorization + "Proxy-Authorization: Basic {}\r\n", + base64::encode(authorization) ); } let _ = write!(connect_request, "Host: {0}:{1}\r\n\r\n", host, port); -- 2.30.2