From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 06B547BBE5; Wed, 13 Jul 2022 11:43:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1EE32FA51; Wed, 13 Jul 2022 11:43:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 13 Jul 2022 11:43:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 54FF6421AC; Wed, 13 Jul 2022 11:43:18 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Date: Wed, 13 Jul 2022 11:43:10 +0200 Message-Id: <20220713094317.2423116-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup/common/storage/wt v2] add tar.zst download in pve X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 09:43:20 -0000 like we have the tar.zst download button for pbs itself, add it for pve for both vms and container file-restore pve-storage depends on pve-common, which depends on proxmox-backup, (we must add the recently bumped proxmox-compression as a dependency; also for the restore-daemon) changes from v1: * split format into 'format' and 'zstd' * also use those parameters for file-restore (keep 'tar' for the pve api for gui compatibility) * use an '#[api]' enum for the format type i kept the 'tar' for the pve api, since that way it makes it easily compatible with the current gui. I'd understand that we maybe also here want to have the 'format'/'zst' options and simply pass them through in that case, we "have" to adapt the pbs-api too since there we already have the 'tar' parameter, or we have to have two codepaths for the gui depending which api we want to use. No problem for a v3 either way, there just was not really an feedback on that in my previous versions. proxmox-backup: Dominik Csapak (4): file-restore: update dependencies pbs-api-types: add FileRestoreFormat type restore-daemon: add 'format' and 'zstd' parameters to the 'extract' handler file-restore: add 'format' and 'zstd' parameters to 'extract' command pbs-api-types/src/file_restore.rs | 15 +++ proxmox-file-restore/Cargo.toml | 4 +- proxmox-file-restore/src/block_driver.rs | 12 ++- proxmox-file-restore/src/block_driver_qemu.rs | 15 +-- proxmox-file-restore/src/main.rs | 100 +++++++++++++++--- .../src/proxmox_restore_daemon/api.rs | 46 ++++++-- 6 files changed, 157 insertions(+), 35 deletions(-) pve-common: Dominik Csapak (1): PBSClient: add 'tar' parameter to file_restore_extract src/PVE/PBSClient.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) pve-storage: Dominik Csapak (1): api/filerestore: add 'tar' parameter to 'download' api PVE/API2/Storage/FileRestore.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) proxmox-widget-toolkit: Dominik Csapak (1): window/FileBrowser: enable tar button by default src/window/FileBrowser.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.30.2