From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 470597ADC1 for ; Wed, 6 Jul 2022 13:43:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35F2AAAEC for ; Wed, 6 Jul 2022 13:42:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Jul 2022 13:42:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 78CEE43AF9 for ; Wed, 6 Jul 2022 13:42:51 +0200 (CEST) Date: Wed, 6 Jul 2022 13:42:50 +0200 From: Wolfgang Bumiller To: Hannes Laimer Cc: pbs-devel@lists.proxmox.com Message-ID: <20220706114250.fu4ttzqxjkvjvd5w@casey.proxmox.com> References: <20220705130834.14285-1-h.laimer@proxmox.com> <20220705130834.14285-11-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220705130834.14285-11-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.290 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 08/26] tools: disks: add mount and unmount helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 11:43:22 -0000 On Tue, Jul 05, 2022 at 01:08:16PM +0000, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > src/tools/disks/mod.rs | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs > index 35ec9996..e217ac87 100644 > --- a/src/tools/disks/mod.rs > +++ b/src/tools/disks/mod.rs > @@ -1136,6 +1136,24 @@ pub fn complete_disk_name(_arg: &str, _param: &HashMap) -> Vec .collect() > } > > +pub fn mount_by_uuid(uuid: &str, mountpoint: &str) -> Result<(), Error> { > + let mut command = std::process::Command::new("mount"); > + command.args(&[format!("UUID={}", uuid)]); > + command.arg(mountpoint); > + > + proxmox_sys::command::run_command(command, None)?; > + Ok(()) > +} > + > +pub fn unmount_by_mountpoint(path: &str) -> Result<(), Error> { > + let mut command = std::process::Command::new("umount"); > + command.arg("-l"); I'm really not a fan of using `-l` at all. This would pull the device out from any current user of it. Anything not exclusively using `openat()` on an already open directory handle to it will start to simply keep using the paths without the disk mounted. I'd rather have it fail when still in use. > + command.arg(path); > + > + proxmox_sys::command::run_command(command, None)?; > + Ok(()) > +} > + > /// Read the FS UUID (parse blkid output) > /// > /// Note: Calling blkid is more reliable than using the udev ID_FS_UUID property. > -- > 2.30.2