From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E950370217 for ; Tue, 21 Jun 2022 10:48:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E1C3E2548 for ; Tue, 21 Jun 2022 10:48:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6EE85257E for ; Tue, 21 Jun 2022 10:48:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 434DC43C11 for ; Tue, 21 Jun 2022 10:48:18 +0200 (CEST) Date: Tue, 21 Jun 2022 10:48:17 +0200 From: Wolfgang Bumiller To: Dominik Csapak Cc: pbs-devel@lists.proxmox.com Message-ID: <20220621084817.gxijquc3ncxxgagr@casey.proxmox.com> References: <20220620075113.730615-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620075113.730615-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.304 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [api.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] restore-daemon: make file listing 'streaming' X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 08:48:19 -0000 applied, thanks On Mon, Jun 20, 2022 at 09:51:13AM +0200, Dominik Csapak wrote: > this prevents an oom kill when listing large directories. > Without this, i'd get an oom kill in the restore vm when > i tried to list a directory with ~60000 entries, but with this, > i'd get the response for even 250000 entries > > Signed-off-by: Dominik Csapak > --- > at 250000 files, the gui did not work anymore, but that's a different > problem altogether (i got 'Maximum call stack size exceeded' in extjs code) > > proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs > index aeb5a71d..91afe5e3 100644 > --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs > +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs > @@ -116,6 +116,7 @@ fn get_dir_entry(path: &Path) -> Result { > } > > #[api( > + streaming: true, > input: { > properties: { > "path": { > -- > 2.30.2