From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 774C570BB2 for ; Wed, 15 Jun 2022 10:17:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68FDD273CE for ; Wed, 15 Jun 2022 10:17:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 707D0273C5 for ; Wed, 15 Jun 2022 10:17:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 41ADD43B52 for ; Wed, 15 Jun 2022 10:17:04 +0200 (CEST) Date: Wed, 15 Jun 2022 10:17:02 +0200 From: Wolfgang Bumiller To: Hannes Laimer Cc: Dominik Csapak , pbs-devel@lists.proxmox.com Message-ID: <20220615081702.x5jpewiforrrbnsr@wobu-vie.proxmox.com> References: <20220608085154.11271-1-h.laimer@proxmox.com> <20220615075842.uipxdoqc45eumcri@wobu-vie.proxmox.com> <42879b0d-02e3-9d62-03c6-946d8ea00742@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <42879b0d-02e3-9d62-03c6-946d8ea00742@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.311 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 08:17:05 -0000 On Wed, Jun 15, 2022 at 10:10:37AM +0200, Hannes Laimer wrote: > > > Am 15.06.22 um 10:08 schrieb Dominik Csapak: > > On 6/15/22 09:58, Wolfgang Bumiller wrote: > > > On Wed, Jun 08, 2022 at 08:51:50AM +0000, Hannes Laimer wrote: > > > > In order to work with the existing frontend component for displying the > > > > disklist, either > > > > * the partition data has to be return with the same struct a disk is > > > >    returned. Which leads to the same struct being used for different > > > >    things -> quite a few fields are always empty for partitions > > > > and a new > > > >    'type' field would be needed. Also the code structure in PBS > > > > has to be > > > >    changed quite a bit. > > > > * the existing frontend has to be adjusted to handle data from PVE and > > > >    PBS properly. > > > > > > > > I went with the second option because the adjustments nedded in the UI > > > > compenent were minimal and, IMHO, adjusting the API to fit the UI is the > > > > wrong direction. > > > > > > > > For the mount status to shown in the UI, the patch[1] sent to > > > > pve-devel for > > > > the 'mounted' column is needed. > > > > > > > > NOTE: The partition data will be needed in later patches for removable > > > > datastores. > > > > > > > > v1->v2: > > > >   * use builder pattern for queries as suggested by Wolfgang > > > >   * move mounted out of Enum and add filesystem string > > > >   * add missing zfsreserve usage type > > > >   * add 'mounted' column to disklist (separate patch[1]) > > > > > > > > > > > > [1] https://lists.proxmox.com/pipermail/pve-devel/2022-June/053211.html > > > > > > @Dominik: Not sure how to deal with the above patch linked, since AFAICT > > > right now the added column is (currently) pbs specific. > > > > > > Should the visibility of the mounted column be configurable? > > > Then again, we probably want to change PVE::Diskmanage & API to return > > > the mounted boolean as well? Currently it just slams a " (mounted)" text > > > onto the file system type, which is rather awkward (and does not happen > > > at all for eg. an ESP partition, which can definitely be mounted...). > > > > > > Though I suppose the series would still work without it, so I guess we > > > can apply this regardless? > > > > > > mhmm... i agree that we probably want to add that column for pve too... > > as an interim solution we could have a 'computed' field/renderer > > that takes either the 'mounted' column or tries to parse the '(mounted)' > > part > > of the 'used' one. > > > > once we have the mounted field in pve too, we can drop that and switch > > to that > > > btw, there was a seconds patch that added 'mounted' to the pve API [1], I > just did not link it > > [1] https://lists.proxmox.com/pipermail/pve-devel/2022-June/053213.html Ah, I should have just used my mail client instead of clicking the link, would have been more obvious ;-)