From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1529271C4A for ; Fri, 10 Jun 2022 10:53:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CEF425227 for ; Fri, 10 Jun 2022 10:52:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8CEB82521C for ; Fri, 10 Jun 2022 10:52:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 641A742F9A for ; Fri, 10 Jun 2022 10:52:57 +0200 (CEST) Date: Fri, 10 Jun 2022 10:52:56 +0200 From: Wolfgang Bumiller To: Stefan Sterz Cc: pbs-devel@lists.proxmox.com Message-ID: <20220610085256.2vzgftzhkazoy2np@wobu-vie.proxmox.com> References: <20220610081325.96912-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610081325.96912-1-s.sterz@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.319 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: config: remove duplicate privilege lookup in cached_user_info X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 08:53:28 -0000 Any reason for the "fix: " prefix in the commit message, though? This just seems to remove something redundant and not actually fix an issue? Or am I missing something? Code-wise it seems fine, so I'd apply it, but I'd drop the 'fix' prefix? On Fri, Jun 10, 2022 at 10:13:25AM +0200, Stefan Sterz wrote: > `lookup_privs` just uses `lookup_privs_details` but ignores the > propagated privileges it returns. thus, the lookup here is redundant > as it is immediately followed by a call to `lookup_privs_details` with > the same parameters. > > Signed-off-by: Stefan Sterz > --- > pbs-config/src/cached_user_info.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/pbs-config/src/cached_user_info.rs b/pbs-config/src/cached_user_info.rs > index 8dd2375a..b9534b80 100644 > --- a/pbs-config/src/cached_user_info.rs > +++ b/pbs-config/src/cached_user_info.rs > @@ -170,7 +170,6 @@ impl CachedUserInfo { > if auth_id.is_token() { > // limit privs to that of owning user > let user_auth_id = Authid::from(auth_id.user().clone()); > - privs &= self.lookup_privs(&user_auth_id, path); > let (owner_privs, owner_propagated_privs) = > self.lookup_privs_details(&user_auth_id, path); > privs &= owner_privs; > -- > 2.30.2