From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D845B71123 for ; Wed, 8 Jun 2022 10:52:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD9975D26 for ; Wed, 8 Jun 2022 10:52:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DC47E5CFA for ; Wed, 8 Jun 2022 10:52:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 24C5E43A8C for ; Wed, 8 Jun 2022 10:52:42 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Wed, 8 Jun 2022 08:51:50 +0000 Message-Id: <20220608085154.11271-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [directory.rs, mod.rs, proxmox.com, zfs.rs] Subject: [pbs-devel] [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 08:52:44 -0000 In order to work with the existing frontend component for displying the disklist, either * the partition data has to be return with the same struct a disk is returned. Which leads to the same struct being used for different things -> quite a few fields are always empty for partitions and a new 'type' field would be needed. Also the code structure in PBS has to be changed quite a bit. * the existing frontend has to be adjusted to handle data from PVE and PBS properly. I went with the second option because the adjustments nedded in the UI compenent were minimal and, IMHO, adjusting the API to fit the UI is the wrong direction. For the mount status to shown in the UI, the patch[1] sent to pve-devel for the 'mounted' column is needed. NOTE: The partition data will be needed in later patches for removable datastores. v1->v2: * use builder pattern for queries as suggested by Wolfgang * move mounted out of Enum and add filesystem string * add missing zfsreserve usage type * add 'mounted' column to disklist (separate patch[1]) [1] https://lists.proxmox.com/pipermail/pve-devel/2022-June/053211.html * proxmox-backup Hannes Laimer (3): api2: disks endpoint return partitions disks: use builder pattern for querying disk usage ui: disks: show partitions by default src/api2/node/disks/directory.rs | 6 +- src/api2/node/disks/mod.rs | 19 ++- src/api2/node/disks/zfs.rs | 2 +- src/tools/disks/mod.rs | 206 +++++++++++++++++++++++++++++-- www/panel/StorageAndDisks.js | 1 + 5 files changed, 215 insertions(+), 19 deletions(-) * proxmox-widget-toolkit Hannes Laimer (1): ui: DiskLisk: handle partition data from PBS backend src/panel/DiskList.js | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) -- 2.30.2