From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4116E73590 for ; Fri, 27 May 2022 12:58:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 333BAD111 for ; Fri, 27 May 2022 12:58:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 64C3ED103 for ; Fri, 27 May 2022 12:58:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B123438C0 for ; Fri, 27 May 2022 12:58:02 +0200 (CEST) From: Daniel Tschlatscher To: pbs-devel@lists.proxmox.com Date: Fri, 27 May 2022 12:57:27 +0200 Message-Id: <20220527105728.132412-1-d.tschlatscher@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 1/1] ext4 filesystems no longer reserve blocks when created as a datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 10:58:34 -0000 Ext4 Filesystems reserve about 5% of all available blocks for usage by the root user. While this can be helpful for root partitions and mount points, it is significantly less so for datastores. Therefore, ext4 filesystems are created with no reserved blocks, increasing the available storage for unpriviliged backup users. Some more rationale can be found in #4077: https://bugzilla.proxmox.com/show_bug.cgi?id=4077 Signed-off-by: Daniel Tschlatscher --- src/tools/disks/mod.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index 568dccbf..9a19f0c1 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -979,10 +979,14 @@ pub fn create_file_system(disk: &Disk, fs_type: FileSystemType) -> Result<(), Er None => bail!("disk {:?} has no node in /dev", disk.syspath()), }; - let fs_type = fs_type.to_string(); - let mut command = std::process::Command::new("mkfs"); - command.args(&["-t", &fs_type]); + + command.args(&["-t", &fs_type.to_string()]); + + if matches!(fs_type, FileSystemType::Ext4) { + command.args(&["-m", "0"]); + } + command.arg(disk_path); proxmox_sys::command::run_command(command, None)?; -- 2.30.2