From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 987A171D8B for ; Fri, 20 May 2022 14:42:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E4A01B0CB for ; Fri, 20 May 2022 14:42:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 20F391B09E for ; Fri, 20 May 2022 14:42:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E5AAB42FA9 for ; Fri, 20 May 2022 14:42:29 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 20 May 2022 14:42:28 +0200 Message-Id: <20220520124228.3368960-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220520124228.3368960-1-d.csapak@proxmox.com> References: <20220520124228.3368960-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup 5/5] datastore: make 'filesystem' the default sync-level X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 12:42:37 -0000 Signed-off-by: Dominik Csapak --- docs/storage.rst | 4 ++-- pbs-api-types/src/datastore.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/storage.rst b/docs/storage.rst index 8ca696cd..089d5e53 100644 --- a/docs/storage.rst +++ b/docs/storage.rst @@ -344,13 +344,13 @@ and only available on the CLI: the crash resistancy of backups in case of a powerloss or hard shutoff. There are currently three levels: - - `none` (default): Does not do any syncing when writing chunks. This is fast + - `none` : Does not do any syncing when writing chunks. This is fast and normally ok, since the kernel eventually flushes writes onto the disk. The kernel sysctls `dirty_expire_centisecs` and `dirty_writeback_centisecs` are used to tune that behaviour, while the default is to flush old data after ~30s. - - `filesystem` : This triggers a ``syncfs(2)`` after a backup, but before + - `filesystem` (default): This triggers a ``syncfs(2)`` after a backup, but before the task returns `OK`. This way it is ensured that the written backups are on disk. This is a good balance between speed and consistency,. Note that the underlying storage device sitll needs to protect itself against diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs index 6563aa73..5bc45948 100644 --- a/pbs-api-types/src/datastore.rs +++ b/pbs-api-types/src/datastore.rs @@ -241,7 +241,7 @@ pub enum DatastoreFSyncLevel { impl Default for DatastoreFSyncLevel { fn default() -> Self { - DatastoreFSyncLevel::None + DatastoreFSyncLevel::Filesystem } } -- 2.30.2