From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E52AC71715 for ; Thu, 12 May 2022 14:23:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DD3A226F98 for ; Thu, 12 May 2022 14:23:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 612EA26F8F for ; Thu, 12 May 2022 14:23:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 355AA434AC for ; Thu, 12 May 2022 14:23:53 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 12 May 2022 14:23:52 +0200 Message-Id: <20220512122352.2734887-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix losing selection on store load X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 12:23:53 -0000 instead of using 'replaceChild', simply set the appropriate properties. when using the 'nodeUpdate' (protected function of extjs, intended to be overwritten) instead of the private 'updateNode', it will be called when the properties change this way, the treenode stays the same and we can keep the selection Signed-off-by: Dominik Csapak --- www/NavigationTree.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/www/NavigationTree.js b/www/NavigationTree.js index eea1d158..577310fd 100644 --- a/www/NavigationTree.js +++ b/www/NavigationTree.js @@ -130,9 +130,10 @@ Ext.define('PBS.store.NavigationStore', { Ext.define('CustomTreeListItem', { extend: 'Ext.list.TreeItem', xtype: 'qtiptreelistitem', - updateNode: function(node, oldNode) { + + nodeUpdate: function(node, modifiedFieldNames) { + this.callParent(arguments); const qtip = node ? node.get('qtip') : null; - this.callParent([node, oldNode]); if (qtip) { this.element.dom.setAttribute('data-qtip', qtip); } else { @@ -261,17 +262,18 @@ Ext.define('PBS.view.main.NavigationTree', { iconCls = 'fa fa-database pmx-tree-icon-custom maintenance'; } - const child = { - text: name, - qtip, - path: `DataStore-${name}`, - iconCls, - leaf: true, - }; if (getChildTextAt(j).localeCompare(name) !== 0) { - list.insertChild(j, child); + list.insertChild(j, { + text: name, + qtip, + path: `DataStore-${name}`, + iconCls, + leaf: true, + }); } else { - list.replaceChild(child, list.getChildAt(j)); + let oldChild = list.getChildAt(j); + oldChild.set('qtip', qtip); + oldChild.set('iconCls', iconCls); } } -- 2.30.2