From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AEBD170B26 for ; Mon, 9 May 2022 12:41:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5A442B9F9 for ; Mon, 9 May 2022 12:41:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 297FE2B9E7 for ; Mon, 9 May 2022 12:41:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F1E424323E for ; Mon, 9 May 2022 12:41:19 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Mon, 9 May 2022 12:41:19 +0200 Message-Id: <20220509104119.1953106-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220509104119.1953106-1-d.csapak@proxmox.com> References: <20220509104119.1953106-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.120 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/2] api: tape/restore: skip snapshot if owner check failed X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 10:41:50 -0000 instead of aborting the whole restore Signed-off-by: Dominik Csapak --- src/api2/tape/restore.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs index f24ae23c..a7ed119a 100644 --- a/src/api2/tape/restore.rs +++ b/src/api2/tape/restore.rs @@ -433,12 +433,14 @@ fn restore_list_worker( datastore.create_locked_backup_group(backup_dir.as_ref(), restore_owner)?; if restore_owner != &owner { // only the owner is allowed to create additional snapshots - bail!( + task_warn!( + worker, "restore '{}' failed - owner check failed ({} != {})", snapshot, restore_owner, owner ); + continue; } let (media_id, file_num) = if let Some((media_uuid, file_num)) = -- 2.30.2