From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4BBB692E6 for ; Tue, 26 Apr 2022 08:24:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 498CEE8CD for ; Tue, 26 Apr 2022 08:24:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0C525E583 for ; Tue, 26 Apr 2022 08:24:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D865B42A99 for ; Tue, 26 Apr 2022 08:24:17 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 26 Apr 2022 06:23:35 +0000 Message-Id: <20220426062335.6215-7-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220426062335.6215-1-h.laimer@proxmox.com> References: <20220426062335.6215-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 6/6] ui: add tooltip to datastore in maintenance mode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 06:24:24 -0000 Signed-off-by: Hannes Laimer --- Tooltips are already used in pve-manager, but in a TreePanel. For some reason qtips are not available 'out of the box' for TreeList, therefore the custom 'qtiptreelistitem' is needed here. www/NavigationTree.js | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/www/NavigationTree.js b/www/NavigationTree.js index 4f451148..28323c53 100644 --- a/www/NavigationTree.js +++ b/www/NavigationTree.js @@ -121,9 +121,26 @@ Ext.define('PBS.store.NavigationStore', { }, }); +Ext.define('CustomTreeListItem', { + extend: 'Ext.list.TreeItem', + xtype: 'qtiptreelistitem', + updateNode: function(node, oldNode) { + const qtip = node ? node.get('qtip') : null; + this.callParent([node, oldNode]); + if (qtip) { + this.element.dom.setAttribute('data-qtip', qtip); + } else { + this.element.dom.removeAttribute('data-qtip'); + } + }, +}); + Ext.define('PBS.view.main.NavigationTree', { extend: 'Ext.list.Tree', xtype: 'navigationtree', + defaults: { + xtype: 'qtiptreelistitem', + }, controller: { xclass: 'Ext.app.ViewController', @@ -230,14 +247,17 @@ Ext.define('PBS.view.main.NavigationTree', { j++; } - let iconCls = 'fa fa-database'; + let [qtip, iconCls] = ['', 'fa fa-database']; const maintenance = records[i].data.maintenance; if (maintenance) { + const [type, message] = PBS.Utils.parseMaintenanceMode(maintenance); + qtip = `${type}${message ? ': ' + message : ''}`; iconCls = 'fa fa-database pmx-tree-icon-custom maintenance'; } const child = { text: name, + qtip, path: `DataStore-${name}`, iconCls, leaf: true, -- 2.30.2