From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4215ECF18 for ; Wed, 13 Apr 2022 11:12:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28A1B20769 for ; Wed, 13 Apr 2022 11:11:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4297A2074E for ; Wed, 13 Apr 2022 11:11:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 17453414B1 for ; Wed, 13 Apr 2022 11:11:56 +0200 (CEST) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 13 Apr 2022 11:11:51 +0200 Message-Id: <20220413091151.150019-5-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220413091151.150019-1-s.sterz@proxmox.com> References: <20220413091151.150019-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v2 4/4] fix: api: avoid race condition in set_backup_owner X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 09:12:27 -0000 when two clients change the owner of a backup store, a race condition arose. add locking to avoid this. Signed-off-by: Stefan Sterz --- src/api2/admin/datastore.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index 45a576ea..3dbf2246 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -1914,11 +1914,12 @@ pub fn set_backup_owner( let privs = user_info.lookup_privs(&auth_id, &["datastore", &store]); + let owner = datastore.get_owner(&backup_group)?; + let allowed = if (privs & PRIV_DATASTORE_MODIFY) != 0 { // High-privilege user/token true } else if (privs & PRIV_DATASTORE_BACKUP) != 0 { - let owner = datastore.get_owner(&backup_group)?; match (owner.is_token(), new_owner.is_token()) { (true, true) => { @@ -1965,6 +1966,12 @@ pub fn set_backup_owner( new_owner); } + let _guard = datastore.lock_group(&backup_group)?; + + if owner != datastore.get_owner(&backup_group)? { + bail!("{} does not own this group anymore", owner); + } + datastore.set_owner(&backup_group, &new_owner, true)?; Ok(()) -- 2.30.2