From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4496FCEA8 for ; Wed, 13 Apr 2022 11:12:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A84C2076A for ; Wed, 13 Apr 2022 11:11:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2669D2073D for ; Wed, 13 Apr 2022 11:11:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EC8F941A1A for ; Wed, 13 Apr 2022 11:11:55 +0200 (CEST) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 13 Apr 2022 11:11:47 +0200 Message-Id: <20220413091151.150019-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v2 0/4] refactor datastore locking to use tmpfs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 09:12:27 -0000 This series refactors the locking mechanism inside the `DataStore` trait. In a first step locking methods are added and the existing code is refactored to use them. The second commit then adds double stat'ing and adds lock files under '/run' for each group/snapshot. The third commit refactors locking for manifests and brings it in-line with the group/snapshot locks. Finally the fourth commit fixes a race condition when changing the owner of a datastore. changes from v1 (thanks @ Wolfgang Bumiller & Thomas Lamprecht): * split adding locking helpers and move '/run' into two commits * instead of stat'ing the path of lock file twice, only use the file descriptor for one of the stat'ing procedures instead * several improvements to helper functions and documentation Stefan Sterz (4): fix #3935: datastore/api/backup: add locking helpers to datastore fix #3935: datastore/api/backup: move datastore locking to '/run' fix #3935: datastore: move manifest locking to new locking method fix: api: avoid race condition in set_backup_owner pbs-config/src/lib.rs | 7 + pbs-datastore/src/datastore.rs | 190 +++++++++++++++++++-------- pbs-datastore/src/snapshot_reader.rs | 30 +++-- src/api2/admin/datastore.rs | 9 +- src/api2/backup/environment.rs | 4 +- src/api2/backup/mod.rs | 4 +- src/api2/reader/mod.rs | 7 +- src/backup/verify.rs | 12 +- 8 files changed, 180 insertions(+), 83 deletions(-) -- 2.30.2