From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 85A5CCCB0 for ; Tue, 12 Apr 2022 16:43:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77C2E19907 for ; Tue, 12 Apr 2022 16:42:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 090D5198FE for ; Tue, 12 Apr 2022 16:42:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CD44C415E9 for ; Tue, 12 Apr 2022 16:42:55 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com Date: Tue, 12 Apr 2022 16:42:50 +0200 Message-Id: <20220412144250.47174-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: [PATCH] object grid: call rendere with our scope X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 14:43:26 -0000 having window as this scope has zero benefits and while one could already try to get the local scope via some Ext.ComponentQuery query its just nicer to have it easily available. Signed-off-by: Thomas Lamprecht --- Stumbled uppon this when wondering about the way Hannes setup the maintenance mode renderer in his series, this would allow to inline that src/grid/ObjectGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/grid/ObjectGrid.js b/src/grid/ObjectGrid.js index 9f3886e..b355d6d 100644 --- a/src/grid/ObjectGrid.js +++ b/src/grid/ObjectGrid.js @@ -248,7 +248,7 @@ Ext.define('Proxmox.grid.ObjectGrid', { let renderer = rowdef.renderer; if (renderer) { - return renderer(value, metaData, record, rowIndex, colIndex, store); + return renderer.call(me, value, metaData, record, rowIndex, colIndex, store); } return value; -- 2.30.2