From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCE89B048 for ; Wed, 6 Apr 2022 11:40:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D372D289BF for ; Wed, 6 Apr 2022 11:40:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5DEFF289B6 for ; Wed, 6 Apr 2022 11:40:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2E47D41C11 for ; Wed, 6 Apr 2022 11:40:24 +0200 (CEST) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 11:39:52 +0200 Message-Id: <20220406093955.3180508-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v1 0/3] refactor datastore locking to use tmpfs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 09:40:24 -0000 This patch series refactors locking within the datastore trait to use the tmpfs-backed /run directory. Instead of the actual directory hierarchy, each backup group and snapshot gets assigned a lock file based on a hash of the relative path within the given datastore. A second commit also refactors the maniefst locks in the same manor. To avoid a race condition when deleting a lock (e.g. upon group deletion), each lock file will be stat'ed before and after acquiring a lock. If the inodes match, we did not encounter a race condition and are allowed to continue using the lock. Locks will be cleaned up when their respective group/snapshot/manifest is removed. The last commit in this series fixes a race condition that occurs when changing the owner of a datastore. Stefan Sterz (3): fix #3935: datastore/api2/backup: move datastore locking to '/run' fix: datastore: move manifest locking to new locking method fix: api: avoid race condition in set_backup_owner pbs-datastore/src/datastore.rs | 171 ++++++++++++++++++--------- pbs-datastore/src/snapshot_reader.rs | 30 +++-- src/api2/admin/datastore.rs | 9 +- src/api2/backup/environment.rs | 4 +- src/api2/backup/mod.rs | 5 +- src/api2/reader/mod.rs | 7 +- src/backup/verify.rs | 12 +- 7 files changed, 155 insertions(+), 83 deletions(-) -- 2.30.2