From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D23B89FD5 for ; Mon, 4 Apr 2022 11:51:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6D98B493 for ; Mon, 4 Apr 2022 11:51:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 701E6B44B for ; Mon, 4 Apr 2022 11:51:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C6DF458CA for ; Mon, 4 Apr 2022 11:51:05 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Mon, 4 Apr 2022 09:50:45 +0000 Message-Id: <20220404095048.25443-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [SERIES proxmox-backup proxmox-widget-toolkit 0/3] add partitions to disks/list endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 09:51:38 -0000 In order to work with the existing frontend component for displying the disklist, either * the partition data has to be return with the same struct a disk is returned. Which leads to the same struct being used for different things -> quite a few fields are always empty for partitions and a new 'type' field would be needed. Also the code structure in PBS has to be changed quite a bit. * the existing frontend has to be adjusted to handle data from PVE and PBS properly. I went with the second option because the adjustments nedded in the UI compenent were minimal and, IMHO, adjusting the API to fit the UI is the wrong direction. Not sure if the small changes in proxmox-widget-toolkit justify sending this series also to pve-devel. NOTE: The partition data will be needed in later patches for removable datastores. proxmox-backup: Hannes Laimer (2): api2: disks endpoint return partitions ui: disks: show partitions by default src/api2/node/disks/directory.rs | 2 +- src/api2/node/disks/mod.rs | 11 ++- src/api2/node/disks/zfs.rs | 2 +- src/tools/disks/mod.rs | 121 ++++++++++++++++++++++++++++++- www/panel/StorageAndDisks.js | 1 + 5 files changed, 131 insertions(+), 6 deletions(-) proxmox-widget-toolkit: Hannes Laimer (1): DiskList: handle partition data from PBS backend src/panel/DiskList.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) -- 2.30.2