From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 23C4769D5D for ; Fri, 25 Mar 2022 12:44:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B81216BA for ; Fri, 25 Mar 2022 12:43:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9A86D15BF for ; Fri, 25 Mar 2022 12:43:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 69D0D46FB4 for ; Fri, 25 Mar 2022 12:43:43 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 25 Mar 2022 12:43:39 +0100 Message-Id: <20220325114341.3220536-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.149 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 0/2] let users control the amount of task logs saved X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 11:44:14 -0000 by providing a 'task-log-max-days' property which controls how many days (approximately) we save. simpler way would be to configure the amount of archive files, but that does not really translate into a nice user setting (that concept is not really visible to users) alternatively we could change the logrotation that it rotates by date/time instead of size/filecount. there is no gui yet, but should not be hard to do and one can do proxmox-backup-manager node update --task-log-max-days 365 Dominik Csapak (2): config/node: add 'task_log_max_days' config rest-server: add option to rotate task logs by 'max_days' instead of 'max_files' proxmox-rest-server/src/worker_task.rs | 49 +++++++++++++++++++++++--- src/api2/node/config.rs | 4 +++ src/bin/proxmox-backup-proxy.rs | 6 ++++ src/config/node.rs | 4 +++ 4 files changed, 59 insertions(+), 4 deletions(-) -- 2.30.2