From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9AB764E37 for ; Fri, 4 Mar 2022 13:31:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C92F349AD for ; Fri, 4 Mar 2022 13:31:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5ADDD49A4 for ; Fri, 4 Mar 2022 13:31:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2BE7841DD1 for ; Fri, 4 Mar 2022 13:31:11 +0100 (CET) Date: Fri, 4 Mar 2022 13:31:09 +0100 From: Wolfgang Bumiller To: Dominik Csapak Cc: Markus Frank , pbs-devel@lists.proxmox.com Message-ID: <20220304123109.scnkcitqimt3iul5@wobu-vie.proxmox.com> References: <20220301112609.84755-1-m.frank@proxmox.com> <20220304110250.wos6p2z2jby5qexf@wobu-vie.proxmox.com> <93ec49a4-4790-0aef-a763-723f5177ecd5@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <93ec49a4-4790-0aef-a763-723f5177ecd5@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.368 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] fix #3854 paperkey import to proxmox-tape X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 12:31:41 -0000 On Fri, Mar 04, 2022 at 12:50:07PM +0100, Dominik Csapak wrote: > On 3/4/22 12:02, Wolfgang Bumiller wrote: > > nit: @Dominik (since you suggested it): > > do we really want `-file` as a suffix here? > > > > We have these currently: > > in recover: > > --file > > --keyfile (without the dash), and > > in 'inspect': > > --chunk => chunk file > > --decode => apparently where to decode*to* 🤔 > > --keyfile (also no dash) > > manager's 'acme': > > --data => path to plugin-data file > > > > should we just use `--paperkey` here? > > meh... > > '--paperkey': would fit into the existing scheme, but implies > giving the content, not a file... I disagree. > > '--paperkeyfile': it's ugly > > so i suggested '--paperkey-file'... > > but we can ofc use '--paperkey' here, maybe try > to use the content directly if it isn't an existing path? Please no! Well... @Markus, your choice, you can pick one of `--paperkey` or `--paperkey-file`, (and maybe we should rename `--keyfile` to `--key-file`...)