From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C4F3D64B5A for ; Fri, 4 Mar 2022 10:13:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3AD8219D for ; Fri, 4 Mar 2022 10:12:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4BA292193 for ; Fri, 4 Mar 2022 10:12:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 118E546E7B for ; Fri, 4 Mar 2022 10:12:38 +0100 (CET) Date: Fri, 4 Mar 2022 10:12:36 +0100 From: Wolfgang Bumiller To: Hannes Laimer Cc: pbs-devel@lists.proxmox.com Message-ID: <20220304091236.vldevpvyr2s452vb@wobu-vie.proxmox.com> References: <20220222122729.46421-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220222122729.46421-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.370 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v1 1/1] close #3770: pbs-client: add quiet backup flag X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 09:13:14 -0000 On Tue, Feb 22, 2022 at 12:27:29PM +0000, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > this feels 'chunky', having quiet and verbose(which is sometimes called > debug). Maybe some kind general verbosity enum might make sense, but then > it should not just be used here. Agreed! A more general approach might be good. I think we should be more strict about using the log crate's macros (`log::info!(...)`, `log::error!(...)`, `log::debug!(...)`) and not use `println!`/`eprintln!` at all, and have a way to control this (and potentially the target output ) on a per-task basis. (Eg. via thread-locals and wrapper Futures which set those before `poll()`ing the inner future)