From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A19E633F7 for ; Thu, 24 Feb 2022 15:19:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 803AB18F58 for ; Thu, 24 Feb 2022 15:19:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6A8318F35 for ; Thu, 24 Feb 2022 15:19:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7393846E4D for ; Thu, 24 Feb 2022 15:19:03 +0100 (CET) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Thu, 24 Feb 2022 15:18:49 +0100 Message-Id: <20220224141854.3153101-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, config.rs, node.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 0/5] fix #3067: add notes functionality to webui X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 14:19:34 -0000 This series adds support for comments/notes to a PBS node similar to PVE's datacenter or node notes. It's split in two parts, the first two commits add support for a single line comment, similar to the comments already available for datastores. The next three commits refactor this into Markdown-based multi-line comments and add an additional tab to the UI to provide more space. If prefered, I can squash the commits. changes v2 (thanks @ Wolfgang Bumiller): * performance improvements when parsing/writing a node configuration * adjusted multi-line regex to remove superfluous "\s*" * better formatting of rust code Stefan Sterz (5): fix #3067: api: add support for a comment field in node.cfg fix #3067: pbs ui: add support for a notes field in the dashboard fix #3067: api: add multi-line comments to node.cfg fix #3607: ui: make dashboard notes markdown capable fix #3607: ui: add a separate notes view for longer markdown notes pbs-api-types/src/lib.rs | 9 ++ src/api2/node/config.rs | 4 + src/config/node.rs | 14 ++- src/tools/config.rs | 58 +++++++++++- www/Dashboard.js | 110 +++++++++++++--------- www/Makefile | 4 +- www/NavigationTree.js | 6 ++ www/NodeNotes.js | 22 +++++ www/datastore/Summary.js | 6 +- www/panel/MarkdownNotes.js | 151 ++++++++++++++++++++++++++++++ www/{datastore => panel}/Notes.js | 19 +++- 11 files changed, 348 insertions(+), 55 deletions(-) create mode 100644 www/NodeNotes.js create mode 100644 www/panel/MarkdownNotes.js rename www/{datastore => panel}/Notes.js (81%) -- 2.30.2