From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4044960E55 for ; Thu, 17 Feb 2022 18:15:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B43F622402 for ; Thu, 17 Feb 2022 18:15:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0369A22332 for ; Thu, 17 Feb 2022 18:15:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D11D041AF2 for ; Thu, 17 Feb 2022 18:15:13 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Thu, 17 Feb 2022 17:14:51 +0000 Message-Id: <20220217171457.72206-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pull.rs, proxmox-backup-api.rs, restore.rs, datastore.rs, status.rs, maintenance.rs, lib.rs, backup.rs, proxmox-backup-proxy.rs, mod.rs] Subject: [pbs-devel] [PATCH proxmox-backup v9 0/6] closes #3071: maintenance mode for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 17:15:17 -0000 Adds maintenance mode and tracking of active reading/writing operations. The maintenance mode prevents the start of new operations if the type of operation they would perform on the datastore would conflict with the maintenance type that is currently set. This check is performed when lookup_datastore is called. Tasks only call this function once at the beginning, therefore updating the maintenance type cannot interfere with already running tasks. active operations tracking: Changed file layout to now also keep track of the pid+starttime and the counts of operations that that pid started, like this it is possible to not count operations that were started by a dead process, since they are also not active anymore. Whenever the file is updated, also entries of dead processes are removed. When the file is read, only entries of active processes are counted. The UI shows a spinner with the count of conflictintg tasks (the tasks that were started before the maintenance type was updated) next to it. As soon as all conflicting tasks are finished a checkmark appears. v9: - bump proxmox-schema dep to 1.2.1 - loosen MAINTENANCE_MESSAGE_REGEX - MaintenanceMode fn check: use and_then() - ui: properly (un)escape double quotes in message v8: - replace enum with MaintenanceMode struct - impl check function on MaintenanceMode struct - api now encodes type+msg in one string - message has to be encoded to ensure proper parsing (everywhere except the UI the message has to be already encoded when passed, API+CLI) v7: - tracking: fix counting on clone - ui: correct gettext usages + remove usage of capitalize v6: - also use process start time in order to avoid pid clashes(as suggested by Thomas and somehow missed by me in the last version) - now a single call of get_active_operations return reads and writes - improved code structure - don't lock when reading v5: - use simple struct and serde instead of manual parsing for file - move tracking related stuff into new file (task_tracking.rs) v4: - clones are not also tracked - use lockfile, instead of locking the file - track pid of the process which started smth - updating maintenance mode is now always possible - add get_active_operations endpoint for datastore - ui: show count of conflicting tasks (or checkmark if no conflicting operations are active) v3, based on Dominik Csapak 's feedback: - added Operation enum(r/w), as suggested by - added active operation tracking - combine type and message into on field v2: - check for maintenance now directly in lookup_datastore - parameter for checking is now the last acceptable maintenance type, description in commit msg of 2nd patch - ui cleanup Hannes Laimer (6): api-types: add maintenance type datastore: add check for maintenance in lookup pbs-datastore: add active operations tracking api: make maintenance_type updatable api: add get_active_operations endpoint ui: add option to change the maintenance type debian/control | 6 +- pbs-api-types/Cargo.toml | 2 +- pbs-api-types/src/datastore.rs | 24 +++++- pbs-api-types/src/lib.rs | 3 + pbs-api-types/src/maintenance.rs | 78 +++++++++++++++++ pbs-datastore/Cargo.toml | 1 + pbs-datastore/src/datastore.rs | 121 +++++++++++++++++++-------- pbs-datastore/src/lib.rs | 4 + pbs-datastore/src/snapshot_reader.rs | 6 +- pbs-datastore/src/task_tracking.rs | 110 ++++++++++++++++++++++++ src/api2/admin/datastore.rs | 81 ++++++++++++------ src/api2/backup/mod.rs | 4 +- src/api2/config/datastore.rs | 5 ++ src/api2/reader/mod.rs | 6 +- src/api2/status.rs | 4 +- src/api2/tape/backup.rs | 6 +- src/api2/tape/restore.rs | 6 +- src/bin/proxmox-backup-api.rs | 1 + src/bin/proxmox-backup-proxy.rs | 4 +- src/server/mod.rs | 16 +++- src/server/prune_job.rs | 4 +- src/server/pull.rs | 4 +- src/server/verify_job.rs | 4 +- www/Makefile | 1 + www/Utils.js | 23 +++++ www/datastore/OptionView.js | 30 +++++++ www/window/MaintenanceOptions.js | 77 +++++++++++++++++ 27 files changed, 540 insertions(+), 91 deletions(-) create mode 100644 pbs-api-types/src/maintenance.rs create mode 100644 pbs-datastore/src/task_tracking.rs create mode 100644 www/window/MaintenanceOptions.js -- 2.30.2