From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2230263887 for ; Tue, 15 Feb 2022 13:10:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18B6D2CCB0 for ; Tue, 15 Feb 2022 13:10:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 409402CC8A for ; Tue, 15 Feb 2022 13:10:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 187344621C for ; Tue, 15 Feb 2022 13:10:51 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 15 Feb 2022 12:10:39 +0000 Message-Id: <20220215121039.19168-7-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220215121039.19168-1-h.laimer@proxmox.com> References: <20220215121039.19168-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [activetasks.read, maintenanceactivetasks.read] Subject: [pbs-devel] [PATCH proxmox-backup v8 6/6] ui: add option to change the maintenance type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2022 12:10:53 -0000 Signed-off-by: Hannes Laimer --- www/Makefile | 1 + www/Utils.js | 23 ++++++++++ www/datastore/OptionView.js | 30 +++++++++++++ www/window/MaintenanceOptions.js | 72 ++++++++++++++++++++++++++++++++ 4 files changed, 126 insertions(+) create mode 100644 www/window/MaintenanceOptions.js diff --git a/www/Makefile b/www/Makefile index 455fbeec..0952fb82 100644 --- a/www/Makefile +++ b/www/Makefile @@ -61,6 +61,7 @@ JSSRC= \ window/BackupGroupChangeOwner.js \ window/CreateDirectory.js \ window/DataStoreEdit.js \ + window/MaintenanceOptions.js \ window/NotesEdit.js \ window/RemoteEdit.js \ window/TrafficControlEdit.js \ diff --git a/www/Utils.js b/www/Utils.js index 36a94211..b99bec32 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -640,4 +640,27 @@ Ext.define('PBS.Utils', { return `${icon} ${value}`; }, + renderMaintenance: function(mode, activeTasks) { + if (!mode) return gettext('None'); + let [type, _message] = mode.split(","); + type = type.split("=").pop(); + + const conflictingTasks = activeTasks.write + (type === 'offline' ? activeTasks.read : 0); + const checkmarkIcon = ''; + const spinnerIcon = ''; + const conflictingTasksMessage = `${conflictingTasks} conflicting tasks still active`; + const extra = conflictingTasks > 0 ? `| ${spinnerIcon} ${conflictingTasksMessage}` : checkmarkIcon; + + let modeText = Proxmox.Utils.unknownText; + switch (type) { + case 'read-only': + modeText = gettext("Read-only"); + break; + case 'offline': + modeText = gettext("Offline"); + break; + } + return `${modeText} ${extra}`; + }, + }); diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index 5a5e85be..25fe71dc 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -1,3 +1,4 @@ + Ext.define('PBS.Datastore.Options', { extend: 'Proxmox.grid.ObjectGrid', xtype: 'pbsDatastoreOptionView', @@ -6,6 +7,10 @@ Ext.define('PBS.Datastore.Options', { cbindData: function(initial) { let me = this; + me.maintenanceActiveTasks = { + read: 0, + write: 0, + }; me.datastore = encodeURIComponent(me.datastore); me.url = `/api2/json/config/datastore/${me.datastore}`; me.editorConfig = { @@ -18,6 +23,24 @@ Ext.define('PBS.Datastore.Options', { controller: { xclass: 'Ext.app.ViewController', + init: function(view) { + let me = this; + me.callParent(); + view.rows['maintenance-mode'].renderer = + (value) => PBS.Utils.renderMaintenance(value, view.maintenanceActiveTasks); + + me.activeOperationsRstore = Ext.create('Proxmox.data.ObjectStore', { + url: `/api2/json/admin/datastore/${view.datastore}/active-operations`, + interval: 3000, + }); + me.activeOperationsRstore.startUpdate(); + + view.mon(me.activeOperationsRstore, 'load', (store, data, success) => { + me.view.maintenanceActiveTasks.read = data[0].data.value; + me.view.maintenanceActiveTasks.write = data[1].data.value; + }); + }, + edit: function() { this.getView().run_editor(); }, @@ -111,5 +134,12 @@ Ext.define('PBS.Datastore.Options', { }, }, }, + "maintenance-mode": { + required: true, + header: gettext('Maintenance mode'), + editor: { + xtype: 'pbsMaintenanceOptionEdit', + }, + }, }, }); diff --git a/www/window/MaintenanceOptions.js b/www/window/MaintenanceOptions.js new file mode 100644 index 00000000..17f1df64 --- /dev/null +++ b/www/window/MaintenanceOptions.js @@ -0,0 +1,72 @@ +Ext.define('PBS.form.maintenanceType', { + extend: 'Proxmox.form.KVComboBox', + alias: 'widget.pbsMaintenanceType', + + comboItems: [ + ['__default__', gettext('None')], + ['read-only', gettext('Read only')], + ['offline', gettext('Offline')], + ], +}); + +Ext.define('PBS.window.MaintenanceOptions', { + extend: 'Proxmox.window.Edit', + xtype: 'pbsMaintenanceOptionEdit', + mixins: ['Proxmox.Mixin.CBind'], + + subject: gettext('Maintenance mode'), + + width: 450, + fieldDefaults: { + labelWidth: 120, + }, + + items: { + onGetValues: function(values) { + if (values.delete === 'maintenance-type') { + values.delete = 'maintenance-mode'; + } else if (values['maintenance-type']) { + const maybe_message = + values['maintenance-msg'] ? `,message=${encodeURIComponent(values['maintenance-msg'])}` : ''; + values['maintenance-mode'] = `type=${values['maintenance-type']}${maybe_message}`; + } + delete values['maintenance-type']; + delete values['maintenance-msg']; + return values; + }, + xtype: 'inputpanel', + items: [ + { + xtype: 'pbsMaintenanceType', + name: 'maintenance-type', + fieldLabel: gettext('Maintenance Type'), + value: '__default__', + deleteEmpty: true, + }, + { + xtype: 'proxmoxtextfield', + name: 'maintenance-msg', + fieldLabel: gettext('Description'), + }, + ], + }, + setValues: function(values) { + let me = this; + + let options = { + 'maintenance-type': '__default__', + 'maintenance-msg': '', + }; + if (values['maintenance-mode']) { + let [type, message] = values['maintenance-mode'].split(","); + type = type.split("=").pop(); + message = message ? message.split("=")[1] : ""; + options = { + 'maintenance-type': type, + 'maintenance-msg': decodeURIComponent(message), + }; + } + + me.callParent([options]); + }, +}); -- 2.30.2