From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4ACD7637AB for ; Wed, 26 Jan 2022 07:11:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31B42477F for ; Wed, 26 Jan 2022 07:11:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E2B474773 for ; Wed, 26 Jan 2022 07:11:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B3B7343C31; Wed, 26 Jan 2022 07:11:04 +0100 (CET) From: Dietmar Maurer To: pbs-devel@lists.proxmox.com Date: Wed, 26 Jan 2022 07:10:59 +0100 Message-Id: <20220126061059.2796975-1-dietmar@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.464 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, proxmox-backup-proxy.rs, proxmox-backup-api.rs, main.rs] Subject: [pbs-devel] [PATCH proxmox-backup v3] Set MMAP_THRESHOLD to a fixed value (128K) X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 06:11:36 -0000 This reduces RSS size by factor 10-20 when running backups. Signed-off-by: Dietmar Maurer --- Changes since v2: add it to proxmox-restore-daemon Changes since v1: use libc bindings pbs-tools/src/lib.rs | 10 ++++++++++ proxmox-backup-client/src/main.rs | 2 ++ proxmox-restore-daemon/src/main.rs | 3 +++ src/bin/proxmox-backup-api.rs | 2 ++ src/bin/proxmox-backup-proxy.rs | 3 +++ 5 files changed, 20 insertions(+) diff --git a/pbs-tools/src/lib.rs b/pbs-tools/src/lib.rs index 053b3c0c..fa1c2c50 100644 --- a/pbs-tools/src/lib.rs +++ b/pbs-tools/src/lib.rs @@ -8,3 +8,13 @@ pub mod sha; pub mod ticket; pub mod async_lru_cache; + +/// Set MMAP_THRESHOLD to a fixed value (128K) +/// +/// This reduces RSS size by factor 10-20 when running backups (not +/// sure why - anything between 128K and 1M works). +pub fn setup_libc_malloc_opts() { + unsafe { + libc::mallopt(libc::M_MMAP_THRESHOLD, 4096*32); + } +} diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 50682637..a51d5bef 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -1465,6 +1465,8 @@ impl ReadAt for BufferedDynamicReadAt { fn main() { + pbs_tools::setup_libc_malloc_opts(); + let backup_cmd_def = CliCommand::new(&API_METHOD_CREATE_BACKUP) .arg_param(&["backupspec"]) .completion_cb("repository", complete_repository) diff --git a/proxmox-restore-daemon/src/main.rs b/proxmox-restore-daemon/src/main.rs index c2be942b..74d7b147 100644 --- a/proxmox-restore-daemon/src/main.rs +++ b/proxmox-restore-daemon/src/main.rs @@ -38,6 +38,9 @@ lazy_static! { /// This is expected to be run by 'proxmox-file-restore' within a mini-VM fn main() -> Result<(), Error> { + + pbs_tools::setup_libc_malloc_opts(); + if !Path::new(VM_DETECT_FILE).exists() { bail!( "This binary is not supposed to be run manually, use 'proxmox-file-restore' instead." diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs index e6fc5f23..ee037a3b 100644 --- a/src/bin/proxmox-backup-api.rs +++ b/src/bin/proxmox-backup-api.rs @@ -19,6 +19,8 @@ use proxmox_backup::auth_helpers::*; use proxmox_backup::config; fn main() { + pbs_tools::setup_libc_malloc_opts(); + proxmox_backup::tools::setup_safe_path_env(); if let Err(err) = proxmox_async::runtime::main(run()) { diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index 523966cf..13025271 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -73,6 +73,9 @@ use proxmox_backup::server::do_verification_job; use proxmox_backup::server::do_prune_job; fn main() -> Result<(), Error> { + + pbs_tools::setup_libc_malloc_opts(); + proxmox_backup::tools::setup_safe_path_env(); let backup_uid = pbs_config::backup_user()?.uid; -- 2.30.2