From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1B5556306A for ; Mon, 24 Jan 2022 13:32:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A4A121B75 for ; Mon, 24 Jan 2022 13:32:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D0D6B21B0B for ; Mon, 24 Jan 2022 13:32:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB25546147 for ; Mon, 24 Jan 2022 13:32:15 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Mon, 24 Jan 2022 13:31:51 +0100 Message-Id: <20220124123159.27086-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox-backup-proxy.rs, proxmox-backup-api.rs, restore.rs, status.rs, mod.rs, maintenance.rs, backup.rs, lib.rs, pull.rs] Subject: [pbs-devel] [PATCH proxmox-backup v5 0/8] closes #3071: maintenance mode for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 12:32:18 -0000 v5: - use simple struct and serde instead of manual parsing for file - move tracking related stuff into new file (task_tracking.rs) v4: - clones are not also tracked - use lockfile, instead of locking the file - track pid of the process which started smth - updating maintenance mode is now always possible - add get_active_operations endpoint for datastore - ui: show count of conflicting tasks (or checkmark if no conflicting operations are active) v3, based on Dominik Csapak 's feedback: - added Operation enum(r/w), as suggested by - added active operation tracking - combine type and message into on field v2: - check for maintenance now directly in lookup_datastore - parameter for checking is now the last acceptable maintenance type, description in commit msg of 2nd patch - ui cleanup Dominik Csapak (1): api: tape: fix datastore lookup operations Hannes Laimer (6): api-types: add maintenance type datastore: add check for maintenance in lookup pbs-datastore: add active operations tracking api: make maintenance_type updatable api: add get_active_operations endpoint ui: add option to change the maintenance type Thomas Lamprecht (1): datastore: avoid tuple-match, use plain if pbs-api-types/src/datastore.rs | 8 +- pbs-api-types/src/lib.rs | 3 + pbs-api-types/src/maintenance.rs | 83 +++++++++++++++++++ pbs-datastore/Cargo.toml | 1 + pbs-datastore/src/datastore.rs | 119 +++++++++++++++++++-------- pbs-datastore/src/lib.rs | 4 + pbs-datastore/src/snapshot_reader.rs | 6 +- pbs-datastore/src/task_tracking.rs | 92 +++++++++++++++++++++ src/api2/admin/datastore.rs | 82 ++++++++++++------ src/api2/backup/mod.rs | 4 +- src/api2/config/datastore.rs | 5 ++ src/api2/reader/mod.rs | 6 +- src/api2/status.rs | 4 +- src/api2/tape/backup.rs | 6 +- src/api2/tape/restore.rs | 6 +- src/bin/proxmox-backup-api.rs | 1 + src/bin/proxmox-backup-proxy.rs | 6 +- src/server/mod.rs | 16 +++- src/server/prune_job.rs | 4 +- src/server/pull.rs | 4 +- src/server/verify_job.rs | 4 +- www/Makefile | 1 + www/Utils.js | 23 ++++++ www/datastore/OptionView.js | 30 +++++++ www/window/MaintenanceOptions.js | 72 ++++++++++++++++ 25 files changed, 505 insertions(+), 85 deletions(-) create mode 100644 pbs-api-types/src/maintenance.rs create mode 100644 pbs-datastore/src/task_tracking.rs create mode 100644 www/window/MaintenanceOptions.js -- 2.30.2