From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9730C60879 for ; Tue, 11 Jan 2022 10:27:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DC201C059 for ; Tue, 11 Jan 2022 10:27:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E02471C046 for ; Tue, 11 Jan 2022 10:27:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7BD446C45 for ; Tue, 11 Jan 2022 10:27:08 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 11 Jan 2022 10:27:08 +0100 Message-Id: <20220111092708.1683867-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220111092708.1683867-1-d.csapak@proxmox.com> References: <20220111092708.1683867-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: hide rrd chard for io delay if no io_ticks are returned X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 09:27:39 -0000 it makes no sense to show a completely empty graph Signed-off-by: Dominik Csapak --- www/datastore/Summary.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index 1616bd57..c3769257 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -234,6 +234,8 @@ Ext.define('PBS.DataStoreSummary', { }, { xtype: 'proxmoxRRDChart', + itemId: 'ioDelayChart', + hidden: true, title: gettext('IO Delay (ms)'), fields: ['io_delay'], fieldTitles: [gettext('IO Delay')], @@ -288,6 +290,10 @@ Ext.define('PBS.DataStoreSummary', { }, }); + me.mon(me.rrdstore, 'load', function(store, records, success) { + me.down('#ioDelayChart').setVisible(!success || records[0]?.data?.io_ticks !== undefined); + }, undefined, { single: true }); + me.query('proxmoxRRDChart').forEach((chart) => { chart.setStore(me.rrdstore); }); -- 2.30.2