From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 24F2484D73 for ; Thu, 16 Dec 2021 08:52:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 087B31B573 for ; Thu, 16 Dec 2021 08:51:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7C77C1B569 for ; Thu, 16 Dec 2021 08:51:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3D9E5451F2 for ; Thu, 16 Dec 2021 08:51:34 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 16 Dec 2021 08:51:33 +0100 Message-Id: <20211216075133.284357-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.173 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.rs] Subject: [pbs-devel] [PATCH proxmox-backup v4] api: zfs: create zpool with relatime=on X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 07:52:05 -0000 some operations (e.g. garbage collection/restore/etc.) are very read intensive on the chunks, and having atime=on and relatime=off (zfs default) makes those write intensive operations too. Additionally, 'ext4' defaults to relatime, so also change the default for api-created zpools. Signed-off-by: Dominik Csapak --- made an error during rebase (i wrote proxmox_sys::run_command instead of proxmox_sys::command::run_command)... sorry for the noise src/api2/node/disks/zfs.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs index 3682d82f..5161d6be 100644 --- a/src/api2/node/disks/zfs.rs +++ b/src/api2/node/disks/zfs.rs @@ -273,13 +273,15 @@ pub fn create_zpool( crate::tools::systemd::enable_unit(&import_unit)?; } + let mut command = std::process::Command::new("zfs"); + command.arg("set"); if let Some(compression) = compression { - let mut command = std::process::Command::new("zfs"); - command.args(&["set", &format!("compression={}", compression), &name]); - task_log!(worker, "# {:?}", command); - let output = proxmox_sys::command::run_command(command, None)?; - task_log!(worker, "{}", output); + command.arg(&format!("compression={}", compression)); } + command.args(&["relatime=on", &name]); + task_log!(worker, "# {:?}", command); + let output = proxmox_sys::command::run_command(command, None)?; + task_log!(worker, "{}", output); if add_datastore { let lock = pbs_config::datastore::lock_config()?; -- 2.30.2