From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9192B84A66 for ; Wed, 15 Dec 2021 08:39:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89312EF01 for ; Wed, 15 Dec 2021 08:39:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F2FBCEEF6 for ; Wed, 15 Dec 2021 08:39:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBFDF4519F for ; Wed, 15 Dec 2021 08:39:13 +0100 (CET) Date: Wed, 15 Dec 2021 08:39:13 +0100 From: Wolfgang Bumiller To: Dominik Csapak Cc: pbs-devel@lists.proxmox.com Message-ID: <20211215073913.ihd7h7tziduc5mli@olga.proxmox.com> References: <20211214122412.4077902-1-d.csapak@proxmox.com> <20211214122412.4077902-10-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214122412.4077902-10-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.410 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 6/6] api: add metricserver endpoints X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 07:39:14 -0000 On Tue, Dec 14, 2021 at 01:24:12PM +0100, Dominik Csapak wrote: > but in contrast to pve, we split the api by type of the section config, > since we cannot handle multiple types in the updater > > Signed-off-by: Dominik Csapak > --- > + > +#[api()] > +#[derive(Serialize, Deserialize)] > +#[serde(rename_all="kebab-case")] > +#[allow(non_camel_case_types)] ^~~~~~~~~~~~~~~~~~~^ Please don't add more of this nonsense! > +/// Deletable property name > +pub enum DeletableProperty { > + /// Delete the port property. > + port, > + /// Delete the https property. > + https, > + /// Delete the token property. > + token, > + /// Delete the bucket property. > + bucket, > + /// Delete the organization property. > + organization, > + /// Delete the max_body_size property. > + max_body_size, > + /// Delete the verify_tls property. > + verify_tls, > + /// Delete the comment property. > + comment, > +} > +#[api()] > +#[derive(Serialize, Deserialize)] > +#[serde(rename_all="kebab-case")] > +#[allow(non_camel_case_types)] No > +/// Deletable property name > +pub enum DeletableProperty { > + /// Delete the mtu property. > + mtu, > + /// Delete the comment property. > + comment, > +} > +