From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31DE2831D2 for ; Thu, 2 Dec 2021 15:27:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 215EB1AA4C for ; Thu, 2 Dec 2021 15:26:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A71B31AA43 for ; Thu, 2 Dec 2021 15:26:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7C7ED44DBD for ; Thu, 2 Dec 2021 15:26:32 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 2 Dec 2021 15:26:31 +0100 Message-Id: <20211202142631.1200891-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.178 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix opening settings window in datastore panel X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 14:27:03 -0000 When a user directly opened the webui with a fragment that is not the summary, opening of the 'my settings' window fails because the initial set of the columns field triggers a state change, which in turn tries to trigger 'updateColumns'. That fails though, since the columns were not even rendered yet (because we are on a different tab). To fix this, simply return when the panel is not rendered yet. Signed-off-by: Dominik Csapak --- www/datastore/Summary.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index 628f0c60..1616bd57 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -264,6 +264,9 @@ Ext.define('PBS.DataStoreSummary', { if (key !== 'summarycolumns') { return; } + if (!me.rendered) { + return; + } Proxmox.Utils.updateColumns(me); }); -- 2.30.2