From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D7E882D98 for ; Wed, 1 Dec 2021 11:57:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 945FFB34F for ; Wed, 1 Dec 2021 11:57:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E37ABB33C for ; Wed, 1 Dec 2021 11:57:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7934444DD for ; Wed, 1 Dec 2021 11:57:08 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 1 Dec 2021 11:57:07 +0100 Message-Id: <20211201105708.3150068-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211201105708.3150068-1-d.csapak@proxmox.com> References: <20211201105708.3150068-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.181 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 2/3] ui: form/GroupFilter: improve group load callback handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 10:57:39 -0000 if 'me' is already destroyed here, return if records is 'null' (which can happen on a not successful load), load an empty list instead Signed-off-by: Dominik Csapak --- www/form/GroupFilter.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/form/GroupFilter.js b/www/form/GroupFilter.js index 5c75f1d0..11aa24c4 100644 --- a/www/form/GroupFilter.js +++ b/www/form/GroupFilter.js @@ -214,8 +214,11 @@ Ext.define('PBS.form.GroupFilter', { me.setDsStoreUrl(url); me.dsStore.load({ callback: (records) => { + if (me.isDestroyed) { + return; + } me.query('pbsGroupSelector').forEach((selector) => { - selector.getStore().setData(records); + selector.getStore().setData(records || []); }); }, }); -- 2.30.2