From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7759982D34 for ; Wed, 1 Dec 2021 11:57:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B095B34E for ; Wed, 1 Dec 2021 11:57:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BF101B332 for ; Wed, 1 Dec 2021 11:57:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84DE0454C5 for ; Wed, 1 Dec 2021 11:57:08 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 1 Dec 2021 11:57:06 +0100 Message-Id: <20211201105708.3150068-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.181 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: form/GroupFilter: correctly resolve the reference cycle X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 10:57:09 -0000 'record[widget]' does not contain anything since the widgets are in the 'widgets' property so delete that we also have to remove the 'record' entry of the widget so that the widget does not have a link to the record anymore Signed-off-by: Dominik Csapak --- www/form/GroupFilter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/form/GroupFilter.js b/www/form/GroupFilter.js index 453152e2..5c75f1d0 100644 --- a/www/form/GroupFilter.js +++ b/www/form/GroupFilter.js @@ -10,7 +10,8 @@ Ext.define('PBS.form.GroupFilter', { removeReferences: function(record) { for (const widget of Object.keys(record.widgets || {})) { - delete record[widget]; + delete record.widgets[widget].record; + delete record.widgets[widget]; } delete record.widgets; -- 2.30.2