From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B18FE813CE for ; Tue, 23 Nov 2021 13:30:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5DA4B57D for ; Tue, 23 Nov 2021 13:30:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EB47AB573 for ; Tue, 23 Nov 2021 13:30:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3311B45C63 for ; Tue, 23 Nov 2021 13:21:07 +0100 (CET) From: Oguz Bektas To: pbs-devel@lists.proxmox.com Date: Tue, 23 Nov 2021 13:21:02 +0100 Message-Id: <20211123122102.577014-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.775 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.rs] Subject: [pbs-devel] [PATCH backup] zfs: check if given pool name is reserved X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 12:30:22 -0000 man zpool-create: The pool names mirror, raidz, draid, spare and log are reserved, as are names _beginning_ with mirror, raidz, draid, and spare. The vdev specification is described in the Virtual Devices section of zpoolconcepts(7). Signed-off-by: Oguz Bektas --- src/api2/node/disks/zfs.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs index c9a6ac72..58e5a83e 100644 --- a/src/api2/node/disks/zfs.rs +++ b/src/api2/node/disks/zfs.rs @@ -201,6 +201,15 @@ pub fn create_zpool( }; // Sanity checks + + lazy_static::lazy_static! { + // pool names starting with these are reserved + static ref RESERVED_POOL_NAMES: regex::Regex = regex::Regex::new(r"^(mirror|raidz|draid|spare).*$").unwrap(); + } + if RESERVED_POOL_NAMES.is_match(&name) || &name == "log" { + bail!("Pool name {:?} is reserved.", &name); + } + if raidlevel == ZfsRaidLevel::Raid10 && devices.len() % 2 != 0 { bail!("Raid10 needs an even number of disks."); } -- 2.30.2