From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 446A279EB7 for ; Thu, 28 Oct 2021 12:57:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3001D1EE0C for ; Thu, 28 Oct 2021 12:57:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B581F1EE01 for ; Thu, 28 Oct 2021 12:57:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8994845FE9 for ; Thu, 28 Oct 2021 12:57:09 +0200 (CEST) Date: Thu, 28 Oct 2021 12:57:08 +0200 From: Wolfgang Bumiller To: Dominik Csapak Cc: pbs-devel@lists.proxmox.com Message-ID: <20211028105708.3amx2lxnjx3637sm@olga.proxmox.com> References: <20211028094755.3003184-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211028094755.3003184-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.576 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [prune.rs] Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/4] PruneMark: use copied values instead of references X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 10:57:10 -0000 applied series On Thu, Oct 28, 2021 at 11:47:52AM +0200, Dominik Csapak wrote: > the type is small enough > > Signed-off-by: Dominik Csapak > --- > pbs-datastore/src/prune.rs | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/pbs-datastore/src/prune.rs b/pbs-datastore/src/prune.rs > index e66ed408..c144b3db 100644 > --- a/pbs-datastore/src/prune.rs > +++ b/pbs-datastore/src/prune.rs > @@ -11,12 +11,12 @@ use super::BackupInfo; > pub enum PruneMark { Protected, Keep, KeepPartial, Remove } > > impl PruneMark { > - pub fn keep(&self) -> bool { > - *self != PruneMark::Remove > + pub fn keep(self) -> bool { > + self != PruneMark::Remove > } > > - pub fn protected(&self) -> bool { > - *self == PruneMark::Protected > + pub fn protected(self) -> bool { > + self == PruneMark::Protected > } > } > > @@ -202,7 +202,7 @@ pub fn compute_prune_info( > let mark = if info.protected { > PruneMark::Protected > } else { > - *mark.get(&backup_id).unwrap_or(&PruneMark::Remove) > + mark.get(&backup_id).copied().unwrap_or(PruneMark::Remove) > }; > > (info, mark) > -- > 2.30.2