From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id B163679E84
for <pbs-devel@lists.proxmox.com>; Thu, 28 Oct 2021 11:47:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id ACAF81E163
for <pbs-devel@lists.proxmox.com>; Thu, 28 Oct 2021 11:47:58 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id A5DE01E147
for <pbs-devel@lists.proxmox.com>; Thu, 28 Oct 2021 11:47:56 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7970845AD9
for <pbs-devel@lists.proxmox.com>; Thu, 28 Oct 2021 11:47:56 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Thu, 28 Oct 2021 11:47:54 +0200
Message-Id: <20211028094755.3003184-3-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211028094755.3003184-1-d.csapak@proxmox.com>
References: <20211028094755.3003184-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.262 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [snapshot.rs]
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] backup-client: use ()
instead of Value as return type
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 28 Oct 2021 09:47:58 -0000
shorter and we do a conversion anyway
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
proxmox-backup-client/src/snapshot.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
index 46b1db09..a9976fbe 100644
--- a/proxmox-backup-client/src/snapshot.rs
+++ b/proxmox-backup-client/src/snapshot.rs
@@ -377,7 +377,7 @@ async fn update_notes(param: Value) -> Result<Value, Error> {
}
)]
/// Show protection status of the specified snapshot
-async fn show_protection(param: Value) -> Result<Value, Error> {
+async fn show_protection(param: Value) -> Result<(), Error> {
let repo = extract_repository_from_value(¶m)?;
let path = required_string_param(¶m, "snapshot")?;
@@ -411,7 +411,7 @@ async fn show_protection(param: Value) -> Result<Value, Error> {
);
}
- Ok(Value::Null)
+ Ok(())
}
#[api(
@@ -433,7 +433,7 @@ async fn show_protection(param: Value) -> Result<Value, Error> {
}
)]
/// Update Protection Status of a snapshot
-async fn update_protection(protected: bool, param: Value) -> Result<Value, Error> {
+async fn update_protection(protected: bool, param: Value) -> Result<(), Error> {
let repo = extract_repository_from_value(¶m)?;
let path = required_string_param(¶m, "snapshot")?;
@@ -451,7 +451,7 @@ async fn update_protection(protected: bool, param: Value) -> Result<Value, Error
client.put(&path, Some(args)).await?;
- Ok(Value::Null)
+ Ok(())
}
fn protected_cli() -> CliCommandMap {
--
2.30.2