From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F48475C5A for ; Fri, 15 Oct 2021 10:33:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95FEC26745 for ; Fri, 15 Oct 2021 10:33:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EA8B826733 for ; Fri, 15 Oct 2021 10:32:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B93954663F for ; Fri, 15 Oct 2021 10:32:59 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 15 Oct 2021 10:32:59 +0200 Message-Id: <20211015083259.1719868-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211015083259.1719868-1-d.csapak@proxmox.com> References: <20211015083259.1719868-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.294 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/2] tape: improve export_media error message for not found tape X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2021 08:33:30 -0000 'export_media' can handle if the tape is in either a normal slot of the library, or in the drive assigned to the current pool writer. (because we need to lock the drive) if it is, for some reason, in a different drive, the error message 'media is not online' could be slightly confusing for a user, since it would appear in the drive list add the 'or a differen drive' to make it clearer Signed-off-by: Dominik Csapak --- src/tape/pool_writer/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tape/pool_writer/mod.rs b/src/tape/pool_writer/mod.rs index 9ff4a173..58995df3 100644 --- a/src/tape/pool_writer/mod.rs +++ b/src/tape/pool_writer/mod.rs @@ -159,7 +159,7 @@ impl PoolWriter { if let Some(slot) = changer.export_media(label_text)? { task_log!(worker, "exported media '{}' to import/export slot {}", label_text, slot); } else { - task_warn!(worker, "export failed - media '{}' is not online", label_text); + task_warn!(worker, "export failed - media '{}' is not online or in different drive", label_text); } } -- 2.30.2