From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 714976D6A3 for ; Tue, 28 Sep 2021 12:06:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 685CDC2B8 for ; Tue, 28 Sep 2021 12:05:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BFD41C27F for ; Tue, 28 Sep 2021 12:05:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9FC22424CF for ; Tue, 28 Sep 2021 12:05:55 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 28 Sep 2021 12:05:43 +0200 Message-Id: <20210928100548.4873-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pull.rs, datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup 0/5] maintenance mode for datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 10:06:27 -0000 Adds a maintenance mode for datatsores. If a datastore is in maintenance mode it has a maintenance-type and a maintenance-msg. The type specifies what is still allowed on the ds and what is not. Currently there are two types: read only and offline. 'read only' prevents everything that would write something to the ds, but allows to read from it. 'offline' prevents everything on the datastore, neither operation that write nor operations that read form the datastore are allowed. The message is optional and is a short string that describes the reason for the maintenance, it is shown whenever an operation is prevented due to the maintenance. Here 'read only' is less restrictive than 'offline'. In order to check if some operation is allowed in the current maintenance mode a function has to be called before every operation that would be effected by a maintenance. This function recieves an upper bound for 'restrictiveness', so if we want to get the list of available snapshots we have to read from the ds, everything that is less restrictive than 'offline' is fine. Here that means maintenance has to either be off or 'read only'. Already running jobs and operations are not affected. Neither are the modification or creation of jobs, since they just modify a config file that is stored on the host system. (It might make sense to add a possibility to shut down running jobs when maintenance is turned on.) Hannes Laimer (5): pbs-api-types: add maintenance type and msg to ds config pbs-datastore: add check_maintenence function api2: make maintenance type and msg updatable/deletable jobs/api2: add checks for maintenance ui: add maintenance to datastore options pbs-api-types/src/datastore.rs | 33 +++++++++++++++++ pbs-datastore/src/datastore.rs | 18 ++++++++- src/api2/admin/datastore.rs | 48 +++++++++++++++++++++--- src/api2/config/datastore.rs | 8 ++++ src/api2/pull.rs | 5 ++- src/server/gc_job.rs | 5 ++- src/server/prune_job.rs | 4 +- src/server/verify_job.rs | 5 ++- www/Makefile | 1 + www/datastore/OptionView.js | 10 +++++ www/window/MaintenanceOptions.js | 63 ++++++++++++++++++++++++++++++++ 11 files changed, 188 insertions(+), 12 deletions(-) create mode 100644 www/window/MaintenanceOptions.js -- 2.30.2