From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 438256C8CF for ; Thu, 23 Sep 2021 15:47:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 32C7826F42 for ; Thu, 23 Sep 2021 15:47:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1297E26F37 for ; Thu, 23 Sep 2021 15:47:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D83CD44A81 for ; Thu, 23 Sep 2021 15:47:32 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 23 Sep 2021 15:47:32 +0200 Message-Id: <20210923134732.1768609-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.357 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] upid: remove arbitrary 128 max length for UPID X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 13:47:34 -0000 we can easily go beyond that when having long datastore/remote names also because we do 'systemd-encode' them, which means that every special char takes up 4 bytes (e.g. '-' => '\x2d') while we could just increase the lenght to say 256 or 512, i do not really see the benefit to limit this at all, since users cannot create tasks with arbitrary names, and all other fields are generated from other valid types (username, datastore, remote, etc.) Signed-off-by: Dominik Csapak --- pbs-api-types/src/upid.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/pbs-api-types/src/upid.rs b/pbs-api-types/src/upid.rs index ba23a646..3094be2d 100644 --- a/pbs-api-types/src/upid.rs +++ b/pbs-api-types/src/upid.rs @@ -58,7 +58,6 @@ pub const PROXMOX_UPID_FORMAT: ApiStringFormat = pub const UPID_SCHEMA: Schema = StringSchema::new("Unique Process/Task Identifier") .min_length("UPID:N:12345678:12345678:12345678:::".len()) - .max_length(128) // arbitrary .format(&PROXMOX_UPID_FORMAT) .schema(); -- 2.30.2