From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AAD7B6B219 for ; Mon, 20 Sep 2021 09:38:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9682A1C471 for ; Mon, 20 Sep 2021 09:38:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9C661C387 for ; Mon, 20 Sep 2021 09:38:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91B77449B6; Mon, 20 Sep 2021 09:38:17 +0200 (CEST) From: Dietmar Maurer To: pbs-devel@lists.proxmox.com Date: Mon, 20 Sep 2021 09:38:01 +0200 Message-Id: <20210920073813.3178009-3-dietmar@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210920073813.3178009-1-dietmar@proxmox.com> References: <20210920073813.3178009-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.654 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 03/15] move src/tools/daemon.rs to pbs-server workspace X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 07:38:54 -0000 --- pbs-server/Cargo.toml | 1 + {src/tools => pbs-server/src}/daemon.rs | 13 ++++++----- pbs-server/src/lib.rs | 31 ++++++++++++++++++++++++- src/api2/node/mod.rs | 2 +- src/bin/proxmox-backup-api.rs | 3 ++- src/bin/proxmox-backup-proxy.rs | 3 ++- src/tools/mod.rs | 27 --------------------- 7 files changed, 43 insertions(+), 37 deletions(-) rename {src/tools => pbs-server/src}/daemon.rs (97%) diff --git a/pbs-server/Cargo.toml b/pbs-server/Cargo.toml index 366a6e08..9e93fb0e 100644 --- a/pbs-server/Cargo.toml +++ b/pbs-server/Cargo.toml @@ -13,6 +13,7 @@ http = "0.2" hyper = { version = "0.14", features = [ "full" ] } lazy_static = "1.4" libc = "0.2" +log = "0.4" nix = "0.19.1" serde = { version = "1.0", features = [] } serde_json = "1.0" diff --git a/src/tools/daemon.rs b/pbs-server/src/daemon.rs similarity index 97% rename from src/tools/daemon.rs rename to pbs-server/src/daemon.rs index 8c56e053..5401e30c 100644 --- a/src/tools/daemon.rs +++ b/pbs-server/src/daemon.rs @@ -15,8 +15,9 @@ use anyhow::{bail, format_err, Error}; use futures::future::{self, Either}; use proxmox::tools::io::{ReadExt, WriteExt}; +use proxmox::tools::fd::Fd; -use crate::tools::{fd_change_cloexec, self}; +use crate::fd_change_cloexec; #[link(name = "systemd")] extern "C" { @@ -218,7 +219,7 @@ impl Reloadable for tokio::net::TcpListener { // FIXME: We could become "independent" of the TcpListener and its reference to the file // descriptor by `dup()`ing it (and check if the listener still exists via kcmp()?) fn get_store_func(&self) -> Result { - let mut fd_opt = Some(tools::Fd( + let mut fd_opt = Some(Fd( nix::fcntl::fcntl(self.as_raw_fd(), nix::fcntl::FcntlArg::F_DUPFD_CLOEXEC(0))? )); Ok(Box::new(move || { @@ -273,11 +274,11 @@ where ).await?; let server_future = create_service(listener, NotifyReady)?; - let shutdown_future = pbs_server::shutdown_future(); + let shutdown_future = crate::shutdown_future(); let finish_future = match future::select(server_future, shutdown_future).await { Either::Left((_, _)) => { - pbs_server::request_shutdown(); // make sure we are in shutdown mode + crate::request_shutdown(); // make sure we are in shutdown mode None } Either::Right((_, server_future)) => Some(server_future), @@ -285,7 +286,7 @@ where let mut reloader = Some(reloader); - if pbs_server::is_reload_request() { + if crate::is_reload_request() { log::info!("daemon reload..."); if let Err(e) = systemd_notify(SystemdNotify::Reloading) { log::error!("failed to notify systemd about the state change: {}", e); @@ -304,7 +305,7 @@ where } // FIXME: this is a hack, replace with sd_notify_barrier when available - if pbs_server::is_reload_request() { + if crate::is_reload_request() { wait_service_is_not_state(service_name, "reloading").await?; } diff --git a/pbs-server/src/lib.rs b/pbs-server/src/lib.rs index 38dd610c..21a91115 100644 --- a/pbs-server/src/lib.rs +++ b/pbs-server/src/lib.rs @@ -1,4 +1,10 @@ -use anyhow::{bail, Error}; +use std::os::unix::io::RawFd; + +use anyhow::{bail, format_err, Error}; + +use proxmox::tools::fd::Fd; + +pub mod daemon; mod state; pub use state::*; @@ -52,3 +58,26 @@ pub fn fail_on_shutdown() -> Result<(), Error> { Ok(()) } +/// Helper to set/clear the FD_CLOEXEC flag on file descriptors +pub fn fd_change_cloexec(fd: RawFd, on: bool) -> Result<(), Error> { + use nix::fcntl::{fcntl, FdFlag, F_GETFD, F_SETFD}; + let mut flags = FdFlag::from_bits(fcntl(fd, F_GETFD)?) + .ok_or_else(|| format_err!("unhandled file flags"))?; // nix crate is stupid this way... + flags.set(FdFlag::FD_CLOEXEC, on); + fcntl(fd, F_SETFD(flags))?; + Ok(()) +} + +/// safe wrapper for `nix::sys::socket::socketpair` defaulting to `O_CLOEXEC` and guarding the file +/// descriptors. +pub fn socketpair() -> Result<(Fd, Fd), Error> { + use nix::sys::socket; + let (pa, pb) = socket::socketpair( + socket::AddressFamily::Unix, + socket::SockType::Stream, + None, + socket::SockFlag::SOCK_CLOEXEC, + )?; + Ok((Fd(pa), Fd(pb))) +} + diff --git a/src/api2/node/mod.rs b/src/api2/node/mod.rs index aeb4ed2b..4014972d 100644 --- a/src/api2/node/mod.rs +++ b/src/api2/node/mod.rs @@ -155,7 +155,7 @@ async fn termproxy( move |worker| async move { // move inside the worker so that it survives and does not close the port // remove CLOEXEC from listenere so that we can reuse it in termproxy - tools::fd_change_cloexec(listener.as_raw_fd(), false)?; + pbs_server::fd_change_cloexec(listener.as_raw_fd(), false)?; let mut arguments: Vec<&str> = Vec::new(); let fd_string = listener.as_raw_fd().to_string(); diff --git a/src/bin/proxmox-backup-api.rs b/src/bin/proxmox-backup-api.rs index f8539b22..fa846bc8 100644 --- a/src/bin/proxmox-backup-api.rs +++ b/src/bin/proxmox-backup-api.rs @@ -13,7 +13,8 @@ use proxmox_backup::server::{ auth::default_api_auth, rest::*, }; -use proxmox_backup::tools::daemon; +use pbs_server::daemon; + use proxmox_backup::auth_helpers::*; use proxmox_backup::config; diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index d087764e..c7435e1f 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -39,11 +39,12 @@ use pbs_api_types::{ PruneOptions, }; +use pbs_server::daemon; + use proxmox_backup::server; use proxmox_backup::auth_helpers::*; use proxmox_backup::tools::{ PROXMOX_BACKUP_TCP_KEEPALIVE_TIME, - daemon, disks::{ DiskManage, zfs_pool_stats, diff --git a/src/tools/mod.rs b/src/tools/mod.rs index f8b363f5..8fd441b5 100644 --- a/src/tools/mod.rs +++ b/src/tools/mod.rs @@ -2,13 +2,10 @@ //! //! This is a collection of small and useful tools. use std::any::Any; -use std::os::unix::io::RawFd; use anyhow::{bail, format_err, Error}; use openssl::hash::{hash, DigestBytes, MessageDigest}; -pub use proxmox::tools::fd::Fd; - use proxmox_http::{ client::SimpleHttp, client::SimpleHttpOptions, @@ -19,7 +16,6 @@ pub mod apt; pub mod async_io; pub mod compression; pub mod config; -pub mod daemon; pub mod disks; pub mod serde_filter; @@ -111,29 +107,6 @@ pub fn normalize_uri_path(path: &str) -> Result<(String, Vec<&str>), Error> { Ok((path, components)) } -pub fn fd_change_cloexec(fd: RawFd, on: bool) -> Result<(), Error> { - use nix::fcntl::{fcntl, FdFlag, F_GETFD, F_SETFD}; - let mut flags = FdFlag::from_bits(fcntl(fd, F_GETFD)?) - .ok_or_else(|| format_err!("unhandled file flags"))?; // nix crate is stupid this way... - flags.set(FdFlag::FD_CLOEXEC, on); - fcntl(fd, F_SETFD(flags))?; - Ok(()) -} - -/// safe wrapper for `nix::sys::socket::socketpair` defaulting to `O_CLOEXEC` and guarding the file -/// descriptors. -pub fn socketpair() -> Result<(Fd, Fd), Error> { - use nix::sys::socket; - let (pa, pb) = socket::socketpair( - socket::AddressFamily::Unix, - socket::SockType::Stream, - None, - socket::SockFlag::SOCK_CLOEXEC, - )?; - Ok((Fd(pa), Fd(pb))) -} - - /// An easy way to convert types to Any /// /// Mostly useful to downcast trait objects (see RpcEnvironment). -- 2.30.2