From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 707236FBE4 for ; Wed, 1 Sep 2021 10:26:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 682502C8AD for ; Wed, 1 Sep 2021 10:25:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D25CB2C887 for ; Wed, 1 Sep 2021 10:25:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ABD7F4449C for ; Wed, 1 Sep 2021 10:25:44 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 1 Sep 2021 10:25:34 +0200 Message-Id: <20210901082539.1507843-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.459 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, prune.rs, lib.rs] Subject: [pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 08:26:19 -0000 add the means to 'protect' a snapshot against pruning by adding a file '.protected' in the snapshot folder sending as RFC because i am not sure about a couple things, and there is no gui (yet): * does it make sense to protect a snapshot this way? or would it be better to have a 'central' protected list somewhere? (sounds not right though..) * would we want to protect also against manual removal ? or 'remove-vanished' on sync? * how should the ui look? do we want *another* button in the content view? * would it make sense to specify this flag on backup creation too? the finished series would fix #3602 Dominik Csapak (5): pbs-datastore: add protection info to BackupInfo pbs-datastore: skip protected backups in pruning add protected info of snapshots to api and task logs api2/admin/datastore: add get/set_protection ui: PruneInputPanel: add keepReason 'protected' for protected backups pbs-api-types/src/lib.rs | 2 + pbs-datastore/src/backup_info.rs | 20 +++++- pbs-datastore/src/prune.rs | 21 +++--- src/api2/admin/datastore.rs | 112 ++++++++++++++++++++++++++++++- src/server/prune_job.rs | 4 +- www/datastore/Prune.js | 4 ++ 6 files changed, 148 insertions(+), 15 deletions(-) -- 2.30.2